Repository navigation
Restore pocket-wall 75 +0.1/0 authored PMI - #2193
Merged
Merged
Conversation
This was referenced Oct 5, 2026
Owner
Author
|
CI failures in this run are reproducible on current main (db3b053) without this PR: |
pzfreo
enabled auto-merge (squash)
October 6, 2026 06:43
pzfreo
pushed a commit
that referenced
this pull request
Oct 6, 2026
* Prove bore-axis location PMI and orient cylindrical frames * Test geometric tolerance axis extraction * Speed up PMI layout retries for #2192 (#2195) * perf: probe GD&T corridor retries before CAD construction * perf: skip impossible joint principal-view scales * perf: avoid inadmissible no-ISO page proposal * refactor: keep PMI probe within source-shape guards * fix: retain AP242 plan witness stations for Y dimensions * fix: reserve routes for unhinted AP242 linear PMI * refactor: keep PMI reservation within review guards * fix: preserve page choice and authored PMI intent in probe stack --------- Co-authored-by: Paul Fremantle <pzfreo@github.com> --------- Co-authored-by: Paul Fremantle <pzfreo@github.com>
pzfreo
disabled auto-merge
October 6, 2026 07:41
pzfreo
enabled auto-merge (squash)
October 6, 2026 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the missing authored
75 +0.1/0dimension in #2192. Does not close the issue: the bore60dimension and two GD&T frames remain dropped.The STEP source references datum C and a pocket wall with offset face centres. Their centre-to-centre vector is oblique, but the faces share a true X-normal witness at Y=26, Z=10. The extractor now proves that shared witness and selects a plan-view X dimension, then the placement path accepts that view. It also preserves the authored zero lower deviation, rendering
+0.1/0.Evidence: the source fixture originally failed the unprojected station proof; a regression test now checks the source record, label, witness, and queued plan candidates. On an explicit A1 1:2 build the 75 dimension placed in plan and its source no longer produced lint.
scripts/pr-check --staticpassed; 151 focused tests passed (1 slow deselected). A temporary removal of the new witness fallback and of zero-tolerance preservation each made the regression fail.Full lint on main already reports this missing source as
pmi_not_extractedandauthored_dim_source_unresolved. The public repro filters those codes, making it appear silent. Remaining #2192 drops are reported and are not claimed fixed here.