Skip to content

Speed up PMI layout retries for #2192 - #2195

Merged
pzfreo merged 8 commits into
fix/pmi-bore-and-gdt-roomfrom
perf/pmi-gdt-probes
Oct 6, 2026
Merged

pzfreo merged 8 commits into
fix/pmi-bore-and-gdt-roomfrom
perf/pmi-gdt-probes

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

What changes

  • Cache GD&T evidence and reject impossible frame compaction before CAD construction.
  • Skip fixed-scale trials when bare principal views cannot share the sheet.
  • Compile the no-ISO comparison directly on the only admissible page.
  • Preserve AP242 plan/Y witness stations instead of collapsing broad-face references onto one line.
  • Reserve real front/side/plan routes for unhinted source linear dimensions. This restores the source 120 ±0.05 tolerance on the issue 2192 first-pass drawing.
  • Fix a generated-feature test-harness import.

Verification

  • GD&T suite: 101 passed, 1 skipped before source-shape refactor; targeted post-refactor GD&T tests passed.
  • Page-recovery suite: 21 passed.
  • Source-shape suite: 7 passed; relevant new PMI/compose tests passed; Ruff clean.
  • Single PMI build reduced from about 81 seconds to about 56 seconds.

Still open before ready

  • Default CLI with PMI annotation on the issue 2192 STEP did not finish within a bounded 180-second run before the latest reservation fix. No later full-run timing claim yet.
  • Three distinct source 40 dimensions and a datum marker still drop on the first A1 pass, with explicit lint. The no-ISO first pass reports the same losses. This PR does not claim a complete PMI drawing.
  • Parent PR 2194 has failing CI.

Stack: #2193 -> #2194 -> this PR. Refs #2192.

@pzfreo
pzfreo marked this pull request as ready for review October 6, 2026 05:35
@pzfreo
pzfreo merged commit 466a2ff into fix/pmi-bore-and-gdt-room Oct 6, 2026
1 check passed
@pzfreo
pzfreo deleted the perf/pmi-gdt-probes branch October 6, 2026 05:35
pzfreo added a commit that referenced this pull request Oct 6, 2026
* Prove bore-axis location PMI and orient cylindrical frames

* Test geometric tolerance axis extraction

* Speed up PMI layout retries for #2192 (#2195)

* perf: probe GD&T corridor retries before CAD construction

* perf: skip impossible joint principal-view scales

* perf: avoid inadmissible no-ISO page proposal

* refactor: keep PMI probe within source-shape guards

* fix: retain AP242 plan witness stations for Y dimensions

* fix: reserve routes for unhinted AP242 linear PMI

* refactor: keep PMI reservation within review guards

* fix: preserve page choice and authored PMI intent in probe stack

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>
pzfreo added a commit that referenced this pull request Oct 6, 2026
* Fix authored pocket-wall PMI witness and unilateral tolerance

* fix: prove pocket-wall witness on trimmed source faces

* Prove bore location and cylindrical GD&T view (#2194)

* Prove bore-axis location PMI and orient cylindrical frames

* Test geometric tolerance axis extraction

* Speed up PMI layout retries for #2192 (#2195)

* perf: probe GD&T corridor retries before CAD construction

* perf: skip impossible joint principal-view scales

* perf: avoid inadmissible no-ISO page proposal

* refactor: keep PMI probe within source-shape guards

* fix: retain AP242 plan witness stations for Y dimensions

* fix: reserve routes for unhinted AP242 linear PMI

* refactor: keep PMI reservation within review guards

* fix: preserve page choice and authored PMI intent in probe stack

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>

* test: compare styled drawing diagnostics with baseline

* style: format diagnostic comparison test

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant