Repository navigation
Avoid provably futile PMI layout compiles - #2197
Merged
Merged
Conversation
pzfreo
force-pushed
the
perf/pmi-layout-preflight
branch
from
October 6, 2026 10:34
cfdbfbd to
1b5aca2
Compare
pzfreo
commented
Oct 6, 2026
pzfreo
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the two performance changes against ADR 2/5 and the fixed first-/third-angle projection topology. No blocking findings. The scale preflight is a necessary geometric bound (full-page bare spans only), and the repack trigger now excludes tables placed after source PMI/GD&T, which cannot cause their earlier drops. The added tests cover pairwise fit and table-order behavior; targeted tests and static checks passed. The full Ubuntu matrix is still running, so this is a code review, not a CI-green merge recommendation yet.
pzfreo
enabled auto-merge (squash)
October 6, 2026 11:02
This was referenced Oct 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two kinds of futile full drawing compile from automatic PMI layout without adding a runtime cap or relaxing the finished-drawing acceptance checks.
End-to-end on the #2192 Specify plate from the linked gist: 94.5s with normal automatic PMI layout, no algorithmic time limit. It selects A1 1:1 and honestly reports the four remaining source-PMI drops. The successful drawing is not claimed complete. One full assembly still costs about 19-22s, and the bounded arrangement/scale/page checks each require a rendered candidate. This PR does not change which checks can accept a candidate.
Focused geometry, table-trigger and real-PMI tests pass; scripts/pr-check --static passes. Based on merged #2193.