Skip to content

Prove bore location and cylindrical GD&T view - #2194

Merged
pzfreo merged 4 commits into
fix/pmi-pocket-wall-witnessfrom
fix/pmi-bore-and-gdt-room
Oct 6, 2026
Merged

pzfreo merged 4 commits into
fix/pmi-pocket-wall-witnessfrom
fix/pmi-bore-and-gdt-room

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Stacked on #2193. This change addresses two source-geometry errors behind #2192; it does not close the issue or claim normal-size sheet completeness.

A Location_LinearDistance from datum plane C to the vertical bore face is a plane-to-axis location, not the diagonal between face bounding-box centres. The extractor now accepts it only when the referenced plane and finite cylinder have compatible principal axes and an exact point on the trimmed plane face. A plane with a hole at that witness fails closed and remains reported. The actual STEP source now extracts 60 as an X dimension in plan.

The position frames attached to cylindrical bores now use their exact common cylinder axis to select the face-on view. The original code used the largest bounding-box extent, mistaking bore diameter for axis. The actual STEP sources prove Z and now target plan; the bore frame placed on a diagnostic A3 build.

Remaining: the 60 and datum B symbol can still drop on the congested A3 1:1 drawing, and three authored 40 dimensions also drop there. An A1 1:2 diagnostic placed the original #2192 targets but dropped other required dimensions; that oversized result is not an acceptance criterion. The view/attachment-site and normal-size sheet policy need a separate follow-up before #2192 can close.

Checks: scripts/pr-check --static; 34 source-shape/import-boundary tests; new positive and negative support tests; existing four mocked GD&T extraction cases after fail-closed optional-axis handling. Removing the new plane-to-bore proof makes its positive regression fail.

pzfreo and others added 2 commits October 6, 2026 06:35
* perf: probe GD&T corridor retries before CAD construction

* perf: skip impossible joint principal-view scales

* perf: avoid inadmissible no-ISO page proposal

* refactor: keep PMI probe within source-shape guards

* fix: retain AP242 plan witness stations for Y dimensions

* fix: reserve routes for unhinted AP242 linear PMI

* refactor: keep PMI reservation within review guards

* fix: preserve page choice and authored PMI intent in probe stack

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>
@pzfreo
pzfreo merged commit 9d0b8ee into fix/pmi-pocket-wall-witness Oct 6, 2026
7 of 17 checks passed
@pzfreo
pzfreo deleted the fix/pmi-bore-and-gdt-room branch October 6, 2026 06:58
pzfreo added a commit that referenced this pull request Oct 6, 2026
* Fix authored pocket-wall PMI witness and unilateral tolerance

* fix: prove pocket-wall witness on trimmed source faces

* Prove bore location and cylindrical GD&T view (#2194)

* Prove bore-axis location PMI and orient cylindrical frames

* Test geometric tolerance axis extraction

* Speed up PMI layout retries for #2192 (#2195)

* perf: probe GD&T corridor retries before CAD construction

* perf: skip impossible joint principal-view scales

* perf: avoid inadmissible no-ISO page proposal

* refactor: keep PMI probe within source-shape guards

* fix: retain AP242 plan witness stations for Y dimensions

* fix: reserve routes for unhinted AP242 linear PMI

* refactor: keep PMI reservation within review guards

* fix: preserve page choice and authored PMI intent in probe stack

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>

* test: compare styled drawing diagnostics with baseline

* style: format diagnostic comparison test

---------

Co-authored-by: Paul Fremantle <pzfreo@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant