Skip to content

[Nexthop][m4061nhp] Add the platform mapping - #1837

Closed
lotus-nexthop wants to merge 4 commits into
meta:mainfrom
nexthop-ai:lotus.m4061nhp-platform-mapping
Closed

lotus-nexthop wants to merge 4 commits into
meta:mainfrom
nexthop-ai:lotus.m4061nhp-platform-mapping

Conversation

@lotus-nexthop

@lotus-nexthop lotus-nexthop commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

PR commit stack:

  1. [Nexthop][m4340nhp] Introduce m4340nhp platform #1828
  2. [Nexthop][m4061nhp] Introduce the m4061nhp platform #1836
  3. [Nexthop][misc] platform_mapping_v2: Map PROFILE_1600G_8_PAM4_RS544X2N_COPPER #1842
  4. This (top of stack)

Add the m4061nhp platform mapping, generated by platform_mapping_v2/gen.py.

#1842 is in the stack because m4061nhp's port profile mapping uses PROFILE_1600G_8_PAM4_RS544X2N_COPPER (66), which #1842 adds. Without it, gen.py fails with 66 is not a valid PortProfileID.

Test Plan

Note: pre-commit run --from-ref <main> --to-ref <this PR> fails ruff check and ruff format on fboss/lib/platform_mapping_v2/gen.py (from #1837) and fboss/lib/platform_mapping_v2/helpers.py (from #1842). The findings are in existing code: upstream main fails the same hooks on both files with the same results, and this stack adds no new ones.

@lotus-nexthop
lotus-nexthop requested review from a team as code owners October 24, 2026 21:12
@meta-cla meta-cla Bot added the CLA Signed label Oct 24, 2026
@github-actions github-actions Bot added nexthop project:m4061nhp FBOSS project: m4061nhp labels Oct 24, 2026
@lotus-nexthop
lotus-nexthop force-pushed the lotus.m4061nhp-platform-mapping branch from 43d5c1e to 7b55e82 Compare October 24, 2026 22:08
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 24, 2026
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 24, 2026
Add m4061nhp's platform_manager.json and bsp_tests.json, and load both in
ConfigLibTest.

Stacked on meta#1837 (platform mapping,
which carries meta#1836 and meta#1828) and meta#1834
(xcvr_io_65 points at mux channel SMB_MUX_2@1).
@lotus-nexthop
lotus-nexthop force-pushed the lotus.m4061nhp-platform-mapping branch from 7b55e82 to f26cbf6 Compare October 25, 2026 06:40
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
…fault run configs

Add the m4061nhp BSP platform mapping (built from the platform_manager
config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add
the default agent, qsfp and led run configs.

Stacked on meta#1839 (platform service
configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836
and meta#1828).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
…nfigs

Add m4061nhp's sensor_service, fan_service, fw_util, led_manager and
rma_showtech configs, and load each in ConfigLibTest.

Stacked on meta#1838 (platform_manager
configs, which carries meta#1837, meta#1842, meta#1836, meta#1834 and meta#1828) and
meta#1835 (OPTIC_TYPE_1600_GENERIC, which
carries meta#1713 and meta#1756).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
Add m4061nhp's platform_manager.json and bsp_tests.json, and load both in
ConfigLibTest.

Stacked on meta#1837 (platform mapping,
which carries meta#1842, meta#1836 and meta#1828) and
meta#1834 (xcvr_io_65 points at mux
channel SMB_MUX_2@1).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it.

Stacked on meta#1837 (platform mapping,
which carries meta#1842, meta#1836 and meta#1828) and
meta#1714 (multiple management ports).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
…nfigs

Add m4061nhp's sensor_service, fan_service, fw_util, led_manager and
rma_showtech configs, and load each in ConfigLibTest.

Stacked on meta#1838 (platform_manager
configs, which carries meta#1837, meta#1842, meta#1836, meta#1834 and meta#1828) and
meta#1835 (OPTIC_TYPE_1600_GENERIC, which
carries meta#1713 and meta#1756).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
…fault run configs

Add the m4061nhp BSP platform mapping (built from the platform_manager
config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add
the default agent, qsfp and led run configs.

Stacked on meta#1839 (platform service
configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836
and meta#1828).
Add the m4061nhp platform_mapping_v2 inputs and generated mapping, register
m4061nhp with the generator, and add it to the TH6 cases in ProdConfigFactory.

Stacked on meta#1836 (m4061nhp),
meta#1828 (m4340nhp) and
meta#1842
(PROFILE_1600G_8_PAM4_RS544X2N_COPPER = 66).
@lotus-nexthop
lotus-nexthop force-pushed the lotus.m4061nhp-platform-mapping branch from f26cbf6 to 07afe79 Compare October 25, 2026 21:21
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
Add m4061nhp's platform_manager.json and bsp_tests.json, and load both in
ConfigLibTest.

Stacked on meta#1837 (platform mapping,
which carries meta#1842, meta#1836 and meta#1828) and
meta#1834 (xcvr_io_65 points at mux
channel SMB_MUX_2@1).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
…nfigs

Add m4061nhp's sensor_service, fan_service, fw_util, led_manager and
rma_showtech configs, and load each in ConfigLibTest.

Stacked on meta#1838 (platform_manager
configs, which carries meta#1837, meta#1842, meta#1836, meta#1834 and meta#1828) and
meta#1835 (OPTIC_TYPE_1600_GENERIC, which
carries meta#1713 and meta#1756).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
…fault run configs

Add the m4061nhp BSP platform mapping (built from the platform_manager
config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add
the default agent, qsfp and led run configs.

Stacked on meta#1839 (platform service
configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836
and meta#1828).
lotus-nexthop added a commit to nexthop-ai/fboss that referenced this pull request Oct 25, 2026
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it,
plus the synced reference validate_asic_configs_contents compares it to.
check-yaml skips synced references, as it already does generated outputs.

Stacked on meta#1837 (platform mapping,
which carries meta#1842, meta#1836 and meta#1828) and
meta#1714 (multiple management ports).
meta-codesync Bot pushed a commit that referenced this pull request Oct 28, 2026
Summary:
**Pre-submission checklist**
- [ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

PR commit stack:
1. #1828
2. #1836
3. #1842
4. #1837
5. #1834
6. #1838
7. #1713
8. #1756
9. #1843
10. #1835
11. #1839
12. This (top of stack)

Wire m4061nhp into qsfp_service, led_service and wedge_qsfp_util, and add its default run configs.

X-link: #1840

Reviewed By: mikechoifb

Differential Revision: D127666273

Pulled By: xanabani

fbshipit-source-id: 4049d9470fa3d3b3442689b7c5c28ac3f67c2893
@xanabani

Copy link
Copy Markdown
Contributor

merged to fbsource

@xanabani xanabani closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants