Repository navigation
[Nexthop][m4061nhp] Add the asic_config_v3 config - #1841
Open
lotus-nexthop wants to merge 6 commits into
Open
lotus-nexthop wants to merge 6 commits into
lotus-nexthop wants to merge 6 commits into
Conversation
lotus-nexthop
force-pushed
the
lotus.m4061nhp-asic-config
branch
from
October 25, 2026 06:40
9708544 to
08f5130
Compare
2 tasks done
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it, plus the synced reference validate_asic_configs_contents compares it to. check-yaml skips synced references, as it already does generated outputs. Stacked on meta#1837 (platform mapping, which carries meta#1842, meta#1836 and meta#1828) and meta#1714 (multiple management ports).
lotus-nexthop
force-pushed
the
lotus.m4061nhp-asic-config
branch
from
October 25, 2026 21:23
08f5130 to
2b62bea
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
PR commit stack:
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it. The yaml is the same one the default
agent.confin #1840 embeds.#1714 is in the stack because m4061nhp declares its QSFP28 management port as a
mgmt_port_overrideslist entry, which the schema accepts only with #1714.Test Plan
Note:
validate_asic_configs_contentsreportsREFERENCE_MISSINGfor m4061nhp because no internal reference exists yet atfboss/lib/asic_config_v2/synced_asic_configs/m4061nhp.yml.python3 fboss/lib/asic_config_v3/gen.py --fboss-root fboss --platform m4061nhpregeneratesgenerated/default.ymlbyte for byte, and the nine existing platforms regenerate unchanged.validate_asic_configs_schemaspasses.Note:
pre-commit run --from-ref <main> --to-ref <this PR>failsruff checkandruff formatonfboss/lib/platform_mapping_v2/gen.py(from #1837) andfboss/lib/platform_mapping_v2/helpers.py(from #1842). The findings are in existing code: upstream main fails the same hooks on both files with the same results, and this stack adds no new ones.