Repository navigation
[Nexthop][m4061nhp] Add the sensor, fan, fw_util, LED and showtech configs - #1839
Closed
lotus-nexthop wants to merge 11 commits into
Closed
lotus-nexthop wants to merge 11 commits into
lotus-nexthop wants to merge 11 commits into
Conversation
1 of 2 tasks
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
…fault run configs Add the m4061nhp BSP platform mapping (built from the platform_manager config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add the default agent, qsfp and led run configs. Stacked on meta#1839 (platform service configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836 and meta#1828).
lotus-nexthop
force-pushed
the
lotus.m4061nhp-platform-services
branch
from
October 25, 2026 06:40
b67d979 to
7edffd6
Compare
2 tasks done
lotus-nexthop
force-pushed
the
lotus.m4061nhp-platform-services
branch
from
October 25, 2026 17:42
7edffd6 to
e9edbcf
Compare
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
…fault run configs Add the m4061nhp BSP platform mapping (built from the platform_manager config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add the default agent, qsfp and led run configs. Stacked on meta#1839 (platform service configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836 and meta#1828).
…um and support in QSFP test (meta#1713)
…nfigs Add m4061nhp's sensor_service, fan_service, fw_util, led_manager and rma_showtech configs, and load each in ConfigLibTest. Stacked on meta#1838 (platform_manager configs, which carries meta#1837, meta#1842, meta#1836, meta#1834 and meta#1828) and meta#1835 (OPTIC_TYPE_1600_GENERIC, which carries meta#1713 and meta#1756).
lotus-nexthop
force-pushed
the
lotus.m4061nhp-platform-services
branch
from
October 25, 2026 21:21
e9edbcf to
5032967
Compare
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
lotus-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Oct 25, 2026
…fault run configs Add the m4061nhp BSP platform mapping (built from the platform_manager config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add the default agent, qsfp and led run configs. Stacked on meta#1839 (platform service configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836 and meta#1828).
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
Summary: **Pre-submission checklist** - [ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` PR commit stack: 1. #1828 2. #1836 3. #1842 4. #1837 5. #1834 6. #1838 7. #1713 8. #1756 9. #1843 10. #1835 11. #1839 12. This (top of stack) Wire m4061nhp into qsfp_service, led_service and wedge_qsfp_util, and add its default run configs. X-link: #1840 Reviewed By: mikechoifb Differential Revision: D127666273 Pulled By: xanabani fbshipit-source-id: 4049d9470fa3d3b3442689b7c5c28ac3f67c2893
Contributor
|
merged to fbsource |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
PR commit stack:
Add m4061nhp's
sensor_service,fan_service,fw_util,led_managerandrma_showtechconfigs, in the same layout as m4062nhp's, and load each inConfigLibTest.#1835 (with #1713, #1756 and #1843 under it) is in the stack because
fan_service.jsonhas a thermal table forOPTIC_TYPE_1600_GENERIC, which #1835 adds. Without it, the build can't parse this config.Test Plan
On m4061nhp hardware, the latest runs of
sensor_service_hw_test,fan_service_hw_test,fw_util_hw_testanddata_corral_service_hw_testpass with these configs.Note:
pre-commit run --from-ref <main> --to-ref <this PR>failsruff checkandruff formatonfboss/lib/platform_mapping_v2/gen.py(from #1837) andfboss/lib/platform_mapping_v2/helpers.py(from #1842). The findings are in existing code: upstream main fails the same hooks on both files with the same results, and this stack adds no new ones.