Repository navigation
[Nexthop][m4061nhp] Wire qsfp_service and led_service, and add the default run configs - #1840
lotus-nexthop wants to merge 13 commits into
Conversation
294b237 to
80712c1
Compare
80712c1 to
837bf95
Compare
…um and support in QSFP test (meta#1713)
…fault run configs Add the m4061nhp BSP platform mapping (built from the platform_manager config), wire it into qsfp_service, led_service and wedge_qsfp_util, and add the default agent, qsfp and led run configs. Stacked on meta#1839 (platform service configs, which carries meta#1835, meta#1756, meta#1713, meta#1838, meta#1834, meta#1837, meta#1842, meta#1836 and meta#1828).
837bf95 to
e071190
Compare
|
@xanabani has imported this pull request. If you are a Meta employee, you can view this in D127666273. |
|
@lotus-nexthop has updated the pull request. You must reimport the pull request before landing. |
|
I believe we need facebook/fbthrift@2547eb3 to get the Build & Run Platform Mapping Generation Verification / Platform-Mapping-Generation-Verification (pull_request) passing, otherwise we hit this error: https://github.com/facebook/fboss/blob/main/fboss/oss/stable_commits/latest_stable_hashes.tar.gz needs to be updated to include the fix. |
Summary: **Pre-submission checklist** - [ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` PR commit stack: 1. #1828 2. #1836 3. #1842 4. #1837 5. #1834 6. #1838 7. #1713 8. #1756 9. #1843 10. #1835 11. #1839 12. This (top of stack) Wire m4061nhp into qsfp_service, led_service and wedge_qsfp_util, and add its default run configs. X-link: #1840 Reviewed By: mikechoifb Differential Revision: D127666273 Pulled By: xanabani fbshipit-source-id: 4049d9470fa3d3b3442689b7c5c28ac3f67c2893
|
Merged in as 1dcde03 closing this PR. |
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
PR commit stack:
Wire m4061nhp into qsfp_service, led_service and wedge_qsfp_util, and add its default run configs.
Test Plan
On m4061nhp hardware, the latest runs of
led_service_hw_test, the qsfp_service hw tests at 1x1.6T and 2x800G, and the qsfp benchmarks pass.Note:
pre-commit run --from-ref <main> --to-ref <this PR>failsruff checkandruff formatonfboss/lib/platform_mapping_v2/gen.py(from #1837) andfboss/lib/platform_mapping_v2/helpers.py(from #1842). The findings are in existing code: upstream main fails the same hooks on both files with the same results, and this stack adds no new ones.