Skip to content

Nest 1/4: typed shims for platform-node's dependencies - #6

Draft
puskuruk wants to merge 28 commits into
nest/basefrom
nest/platform-node-shims
Draft

puskuruk wants to merge 28 commits into
nest/basefrom
nest/platform-node-shims

Conversation

@puskuruk

@puskuruk puskuruk commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Typed ports of the 24 npm packages @nestjs/platform-node pulls in (find-my-way, send, body-parser's parsers, cookie, type-is, mime-types and the rest), under runtime/node/nest/shims, each checked against its pinned npm original by a parity table. scripts/build.mjs resolves the shim packages from there.

Base branch nest/base is main plus the four runtime fix PRs this stack needs (fs.stat, setImmediate, http surface, zlib streams); retarget to main once those merge.

28 commits: tools/nest pins the originals, the mime-db table is generated, then one commit per shim ending with find-my-way and send.

Verification: node tools/nest/check-shims.mjs → 24 shim tables passed, 0 failed (statuses 174 cases, type-is 16,080 cases, …); strict typecheck of runtime/node/nest/shims clean.

Related

Stack: this PR → #7 (2/4, vendor) → #8 (3/4, AOT) → #9 (4/4, benchmark). Base nest/base carries #2, #3, #4 and #5; retarget to main after they merge.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@puskuruk

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant