Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 19, 2026
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 19, 2026 20:25
368dcf1 to
d5a4a03
Compare
Collaborator
Author
|
@coderabbitai review |
|
…he directory in the builtin-modules walk
…p listener registry
…, optional params, backtracking, constraints, off/findRoute/prettyPrint) with its parity table over the package's documented route grammar and options
…eam and on-finished) with its parity table over a fixture tree
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 20, 2026 04:33
d5a4a03 to
042166f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed ports of the 24 npm packages
@nestjs/platform-nodepulls in (find-my-way, send, body-parser's parsers, cookie, type-is, mime-types and the rest), underruntime/node/nest/shims, each checked against its pinned npm original by a parity table.scripts/build.mjsresolves the shim packages from there.Base branch
nest/baseismainplus the four runtime fix PRs this stack needs (fs.stat, setImmediate, http surface, zlib streams); retarget tomainonce those merge.28 commits: tools/nest pins the originals, the mime-db table is generated, then one commit per shim ending with find-my-way and send.
Verification:
node tools/nest/check-shims.mjs→ 24 shim tables passed, 0 failed (statuses 174 cases, type-is 16,080 cases, …); strict typecheck ofruntime/node/nest/shimsclean.Related
Stack: this PR → #7 (2/4, vendor) → #8 (3/4, AOT) → #9 (4/4, benchmark). Base
nest/basecarries #2, #3, #4 and #5; retarget tomainafter they merge.