Skip to content

Nest 2/4: vendor @nestjs/platform-node 12.1.3 typed sources - #7

Draft
puskuruk wants to merge 8 commits into
nest/platform-node-shimsfrom
nest/platform-node-vendor
Draft

puskuruk wants to merge 8 commits into
nest/platform-node-shimsfrom
nest/platform-node-vendor

Conversation

@puskuruk

@puskuruk puskuruk commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Vendors the typed sources of @nestjs/platform-node at nest commit 2b10fb2 (PR nestjs/nest#18063, 12.1.3) under runtime/node/nest, with the type-level edits whole-program strict certification needs, each marked UPSTREAM-DIFF; upstream's comments are kept. tools/nest/build-platform-node.mjs packs the three @nestjs tarballs from the pinned commit, and apps/nest-node-probe carries the Node oracle and two node-vs-compiled probes.

  • 1e141a3 Vendor @nestjs/platform-node 2b10fb2 (12.1.3) typed sources under runtime/node/nest
  • a376e7d Narrow body-parser's catch variable to Error for whole-program strict (UPSTREAM-DIFF)
  • 6cc6f34 Type route-table's find-my-way store as RouteRecord and its methods as HTTPMethod (UPSTREAM-DIFF)
  • d642009 Import content-type by name in the vendored body-parser (UPSTREAM-DIFF)
  • f892bae Type the vendored route table and request for certification
  • ce30946 Type body-parser's errors, urlencoded decoder and poisoning scan for certification
  • 72ceec9 Add tools/nest/build-platform-node.mjs building the @nestjs tarballs from the pinned nest commit
  • 5d218b9 Add nest-node-probe with the PR's three routes, a Node oracle, and node-vs-compiled probes

Verification: ERROR_SUBCLASS_PARITY_OK:8, JSON_UNDEFINED_PARITY_OK:7 (scripts/test-error-subclass.mjs, test-json-undefined.mjs).

Related

Stack: #6 (1/4, shims) → this PR → #8 (3/4, AOT) → #9 (4/4, benchmark). Shows only its own eight commits over nest/platform-node-shims.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@puskuruk

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…pt source has no default export (UPSTREAM-DIFF)
…ams, ParsedQuery, a NodeApp class, no prototype-reassigned params object (UPSTREAM-DIFF)
…certification, with qs's Decoder and a ParsedQs scanQuery in secure-json-parse (UPSTREAM-DIFF)
…de-vs-compiled probes for JSON.stringify of undefined and instanceof over an Error subclass
@puskuruk
puskuruk force-pushed the nest/platform-node-shims branch from d5a4a03 to 042166f Compare October 20, 2026 04:33
@puskuruk
puskuruk force-pushed the nest/platform-node-vendor branch from be6383d to beb3f1d Compare October 20, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant