Skip to content

Add node:zlib streams and brotliDecompress - #5

Open
puskuruk wants to merge 2 commits into
mainfrom
fix/zlib-streams
Open

puskuruk wants to merge 2 commits into
mainfrom
fix/zlib-streams

Conversation

@puskuruk

@puskuruk puskuruk commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

node:zlib gains the stream classes and brotliDecompress; the brotli decoder is a libbrotlidec intrinsic that scripts/build.mjs links only when a unit includes it.

  • e38a199 Add the brotli decoder intrinsic over libbrotlidec and link it from build.mjs when a unit includes it
  • 32f66b1 Add node:zlib streams (Gunzip, Inflate, InflateRaw, Unzip, Gzip, Deflate, DeflateRaw) and brotliDecompress with their facades and compatibility snapshot rows

Verification: node scripts/test-zlib-streams.mjs → ZLIB_STREAMS_PARITY_OK:20; node scripts/test-native-brotli.mjs → NATIVE_BROTLI_OK:8.

Related

Independent of the other three runtime fixes (#2, #3, #4). Branch nest/base is main plus these four and is the base of #6 (Nest 1/4).

…ate, DeflateRaw) and brotliDecompress with their facades and compatibility rows
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ba5ac935-c82c-47bb-9106-40133b6e5547
📥 Commits

Reviewing files that changed from the base of the PR and between 7337902 and 32f66b1.

⛔ Files ignored due to path filters: 2
  • runtime/node/generated/facades/zlib.ts is excluded by !**/generated/**
  • runtime/node/generated/node24-compatibility.json is excluded by !**/generated/**
📒 Files selected for processing: 7
  • apps/nest-node-probe/correctness/zlib-streams.ts
  • plugin/index.mjs
  • runtime/node/gea_node_brotli.hpp
  • runtime/node/zlib.ts
  • scripts/build.mjs
  • scripts/test-native-brotli.mjs
  • scripts/test-zlib-streams.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Add Carrot credits or activate Agent usage billing to use Autofix

@puskuruk

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant