Repository navigation
server: add provider-admin share entities and CRUD - #96
Merged
Merged
Conversation
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
September 16, 2026 21:53
70271a3 to
71c8d30
Compare
littlegrasscao
marked this pull request as ready for review
September 16, 2026 22:24
littlegrasscao
commented
Sep 17, 2026
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
September 22, 2026 16:42
8832768 to
623b1fa
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
September 25, 2026 22:27
d478fe2 to
dc10dd2
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
September 25, 2026 22:32
dc10dd2 to
259348c
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
September 25, 2026 22:37
259348c to
c34e978
Compare
zhu-tom
added this pull request to stack #111
October 1, 2026 18:55
littlegrasscao
removed this pull request from stack #111
October 1, 2026 20:19
littlegrasscao
added this pull request to stack #112
October 1, 2026 20:20
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 2, 2026 16:10
c34e978 to
30b98ab
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 2, 2026 16:40
30b98ab to
b7d3a2e
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 5, 2026 21:25
974e2e8 to
9c50952
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 5, 2026 23:58
9c50952 to
c6bce2a
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 6, 2026 00:05
c6bce2a to
eda1652
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 6, 2026 00:14
eda1652 to
724a4b9
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 13, 2026 22:37
aa23cc9 to
a55d577
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 13, 2026 22:40
a55d577 to
21f4d6e
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 13, 2026 22:44
21f4d6e to
e50801a
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
3 times, most recently
from
October 13, 2026 23:27
ece0aa4 to
26a1486
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 14, 2026 00:56
26a1486 to
d813775
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 14, 2026 19:24
d813775 to
e2d1d47
Compare
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 19, 2026 17:12
e2d1d47 to
c24f7b7
Compare
zhu-tom
approved these changes
Oct 19, 2026
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 19, 2026 22:30
684d02a to
0e69c53
Compare
added 2 commits
October 19, 2026 15:31
littlegrasscao
force-pushed
the
server/split2/07-provider-shares
branch
from
October 19, 2026 22:31
0e69c53 to
2df60b3
Compare
chakankardb
reviewed
Oct 19, 2026
…plify store comments.
chakankardb
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShareEntitypersistence with Hibernate (JpaTransactions) and the provider share API underprovider.base-path(default/api/1.0/opensharing/provider), served byShareAdminServiceon Armeria:POST /shares,GET /shares,GET /shares/{share},PATCH /shares/{share},DELETE /shares/{share}ProviderTokenDecoratorauthenticates every provider request by callingCatalogConnector.authorizewith the bearer token and no privilege. A missing token, or one the catalog cannot authenticate, is 401UNAUTHENTICATEDShareService.createcallscatalog.authorize(CREATE_SHARE); the catalog'suserIdbecomes the share owner, and only the owner may update or delete the share;Ownership.checkdenies a missing owner or user idSELECT ... FOR UPDATE, so concurrent changes to one share run one at a time and each sees what the one before it wrote; an update that waits on a delete gets 404Testing
mvn clean install: 82 tests passedShareServiceTest: creating a share requiresCREATE_SHAREfrom the catalogOwnershipTest: only the owner passes the owner check, and a missing owner or user id never matchesProviderTokenDecoratorTest: a missing token never reaches the catalog, a token the catalog cannot authenticate is 401, other catalog failures are 502, and the authenticated caller reaches the serviceShareAdminServiceTest: share CRUD over HTTP, duplicate and invalid names, partial updates, owner-only deletes, and 404 for missing shares