[littlegrasscao]

Summary

• add SharedDataObjectEntity persistence and ADD / REMOVE object updates to the provider PATCH /shares/{share} API
  • an add resolves the object through CatalogConnector.resolveAsset as the caller, checks its declared type, and records the catalog's asset id and table format. The catalog checks that the caller may select from it
  • sharedAs defaults to the name without its catalog; aliases and source names are unique within a share, and a schema and tables under it cannot both be shared
  • a remove names the object by sharedAs or by catalog name, and must match its type
  • GET /shares/{share}?include_shared_data=true returns the objects; deleting a share deletes them
• an update is atomic, as in Databricks UpdateShare: every remove runs, then every add, then the share's field changes, in one database transaction. If any of them fails, the transaction rolls back and the share is unchanged
  • catalog lookups for the adds finish before the transaction opens, so it holds no connection during remote calls; a catalog failure also leaves the share unchanged
  • because removes run first, an add may reuse an alias that the same request removes, whatever the order of updates
• only the share owner may update it; the share's row lock from server: add provider-admin share entities and CRUD #96 makes concurrent updates run one at a time, so the schema and table checks see each other's adds

Testing

• mvn clean install: 94 tests passed
• ShareAdminServiceTest: adding and removing tables and schemas, default and explicit aliases, unsupported types, duplicate aliases and sources, schema and table conflicts, and removes that need a type and an existing object
• ShareUpdateTransactionTest:
  • removing a table and adding another, then adding a conflicting schema, returns 409; the removed table is still shared, the added table is not, and the comment is unchanged
  • a remove followed by an add the catalog rejects leaves the removed table in the share
  • an add that reuses the alias of a later remove in the same request succeeds
• ShareUpdateConcurrencyTest: adding a schema and a table under it at the same time leaves only one of them (the other is 409), and an update racing a delete gets 200 or 404

Stacked on #96.