Repository navigation
server: grant recipients access to shares - #99
Merged
Merged
Conversation
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
September 18, 2026 20:15
da33e4e to
d1e56b7
Compare
littlegrasscao
marked this pull request as ready for review
September 18, 2026 21:21
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
September 22, 2026 16:42
d1e56b7 to
c10cb84
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
September 25, 2026 22:19
c10cb84 to
fc63b77
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
September 25, 2026 22:27
fc63b77 to
22cd8c1
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
September 25, 2026 22:32
22cd8c1 to
333b4b5
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
September 25, 2026 22:37
333b4b5 to
47a5f26
Compare
zhu-tom
added this pull request to stack #111
October 1, 2026 18:55
littlegrasscao
removed this pull request from stack #111
October 1, 2026 20:19
littlegrasscao
added this pull request to stack #112
October 1, 2026 20:20
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 2, 2026 16:16
47a5f26 to
3cd9812
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 2, 2026 16:40
3cd9812 to
43e75e8
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 5, 2026 20:57
43e75e8 to
1462b39
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 5, 2026 21:25
1462b39 to
0df270f
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 5, 2026 23:59
0df270f to
b83b41e
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 6, 2026 00:06
b83b41e to
47dcb11
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 8, 2026 00:44
030bda8 to
5e17bac
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 9, 2026 23:35
5e17bac to
19a2795
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 13, 2026 23:38
19a2795 to
731183e
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 13, 2026 23:55
731183e to
7c12b02
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 14, 2026 00:06
7c12b02 to
80a1793
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 14, 2026 00:56
80a1793 to
1cd5116
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 14, 2026 19:24
1cd5116 to
177c961
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
2 times, most recently
from
October 15, 2026 18:13
5b53b3f to
a7c5029
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 15, 2026 23:34
a7c5029 to
75433af
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 15, 2026 23:38
75433af to
e1779ac
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 16, 2026 00:40
e1779ac to
496f3e1
Compare
littlegrasscao
force-pushed
the
server/split2/10-share-grants
branch
from
October 19, 2026 17:12
496f3e1 to
e0e59b8
Compare
zhu-tom
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharePermissionEntitypersistence for the privileges recipients hold on shares;SELECTis the only privilege so farGET /shares/{share}/permissionslists who holds which privilege on the share, by recipient name; any caller may listPATCH /shares/{share}/permissionsgrants and revokes privileges on one share for one or more recipients, then returns the share's permissions. Owner only{"changes": [{"recipientName": "<recipient name>", "add": ["SELECT"], "remove": ["SELECT"]}]}; each change revokes before it grants, and changes apply in request orderUpdatePermissions: every grant and revoke runs in one database transaction, and any failure, such as revoking a privilege the recipient does not hold, rolls back the whole requestTesting
mvn clean install: 106 tests passedSharePermissionAdminServiceTest: owner-only grants, case-insensitive recipient names, idempotent grants, listing by any caller, revokes, 404 for revoking an ungranted privilege, and 400 for null changes or privilegesSharePermissionUpdateTransactionTest:SELECTand the second was not granted itSharePermissionConcurrencyTest: two concurrent grants of the same privilege both succeed, and two concurrent revokes return 200 and 404