[littlegrasscao]

Summary

• replace the Spring Boot application with a standalone server on Armeria: OpenSharingServer loads the configured catalog, builds OpenSharing, and listens on server.port; main serves until the JVM shuts down and rejects program arguments
• ServerProperties reads server.properties from the classpath. A JVM system property overrides a key, then an environment variable with the same name or its upper snake case form, such as SERVER_PORT. A blank value anywhere keeps the default
  • server.port (default 8080), catalog.type (only local so far), and catalog.local.file (default classpath:local-catalog.yml)
• LocalCatalogLoader.load(location) reads the local catalog from a classpath: resource or a file path, with or without file:
• add OpenSharing.builder() in core, which builds OpenSharing from the parts its host supplies; it requires a CatalogConnector
• package a runnable opensharing-server-*-exec.jar with the shade plugin, and log through Logback
• pin Netty to 4.1.126.Final through netty-bom, over the 4.1.108 Armeria brings, for its HTTP/2 fixes; the AWS SDK already in core expects it too
• drop the Spring Boot dependencies and application.yml. Nothing read its keys yet; each comes back where it is used:
  • the Jackson settings (no nulls, ISO dates, case-insensitive enums) live in ApiJson (server: return protocol error bodies for HTTP failures #92), so every host renders responses the same way
  • the datasource and schema settings move to hibernate.properties (server: add provider-admin share entities and CRUD #96)
  • the protocol prefix becomes protocol.base-path (server: redeem recipient activation URLs into a profile #100)
  • page sizes follow the protocol's fixed limits (server: page the provider list APIs #117)
  • credential lifetime is the catalog's default (protocol: generate temporary table credentials #107)
  • GCS URL signing uses the catalog-vended key or Google application default credentials (protocol: sign recipient file URLs for cloud storage #108)
  • presigned URLs last an hour, or until the catalog credentials expire, and need the table's url access mode, replacing delta.url-ttl and delta.url-access-enabled (protocol: Query Table snapshot API #109)

Testing

• mvn clean install: 41 tests passed
• OpenSharingServerTest: loads the configured local catalog, rejects a missing catalog file and an unknown catalog type, builds OpenSharing with the configured catalog, and rejects program arguments
• ServerPropertiesTest: reads server.properties from the classpath, keeps the default of blank keys and blank overrides, lets system properties override the file, reads environment variables by key or upper snake case name, and rejects a port that is not a number

[chakankardb]

Is the description correct (Spring Boot application)?

[chakankardb]

From claude: Following on from the description question above: the config keys in the deleted application.yml aren't carried over to server.properties: protocol-prefix, asset-credentials.ttl, pagination limits, storage.gcs-service-account-key-file, delta.*, and the Jackson settings (non_null, ISO dates, case-insensitive enums). Nothing reads them yet, but the Jackson settings change what protocol responses look like, so is dropping them intended? If so, could the updated description list them?

[littlegrasscao]

@chakankardb On the description: it was stale (it still described the Spring Boot application). It's rewritten to match the current diff.

On the dropped application.yml keys: yes, that's intended. Nothing read them in this PR, and each comes back in the PR that uses it. The updated description lists where:

• The Jackson settings (no nulls, ISO dates, case-insensitive enums) live in ApiJson (server: return protocol error bodies for HTTP failures #92). Every OpenSharing endpoint uses that mapper rather than the host's, so responses look the same in any host.
• The datasource settings move to hibernate.properties (server: add provider-admin share entities and CRUD #96).
• protocol-prefix becomes protocol.base-path (server: redeem recipient activation URLs into a profile #100).
• Page sizes follow the protocol's fixed limits (server: page the provider list APIs #117).
• Credential lifetime is the catalog's default (protocol: generate temporary table credentials #107).
• GCS signing uses the catalog-vended key or Google application default credentials (protocol: sign recipient file URLs for cloud storage #108).
• Presigned URLs last an hour, or until the catalog credentials expire, and need the table's url access mode, replacing delta.* (protocol: Query Table snapshot API #109).