Repository navigation
Partial reloads 11: Keep a chambered round through a Tachi reload - #2297
Closed
sunzenshen wants to merge 1 commit into
Closed
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
The Tachi script gets the reload phases from neoAssets and a chamber
slot: #base "weapon_tachi_reload_phases.txt", "ReloadPhases" {} and
"ChamberedRound" "1", as the ZR68 guns have them. The generic chamber
code then gives 15+1 after a tactical reload and 14+1 after a dry one,
with the chamber filled at the ammo credit. No code changes.
sunzenshen
force-pushed
the
stack/reload-zr68c/57-zr68l
branch
from
November 10, 2026 02:10
94d3e09 to
eac260d
Compare
sunzenshen
force-pushed
the
stack/reload-zr68c/70-tachi
branch
from
November 10, 2026 02:10
14a64f4 to
fa3bdc8
Compare
sunzenshen
marked this pull request as ready for review
November 10, 2026 07:36
sunzenshen
marked this pull request as draft
November 12, 2026 06:54
This was referenced Nov 13, 2026
Closed
Contributor
Author
|
Closing to clear the board in favor of the PR stack of sunzenshen#36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on NeotokyoRebuild/neoAssets#183 (layer 11: the Tachi chamber phases file).
Partial reloads 11: add a chambered round to the Tachi. This PR builds on layer 10 (#2296, the ZR68-L) and pairs with
neoAssets layer 11. Next: #2298 (12, the Kyla).
The chamber code of layer 08 (#2294) is generic: a weapon gets a chamber slot from its weapon script and a phases file
that says when the chamber holds a round. This PR adds the three script lines; it has no code changes.
#base "weapon_tachi_reload_phases.txt","ReloadPhases" {},"ChamberedRound" "1", as the ZR68 gunshave them. The phases file has one
3_cyclerow each forreloadandreloadempty, at the ammo credit (1.733 s).The Tachi keeps its shipped reload clips and sounds whole: a tactical reload gives
15+1, a dry reload14+1.master; a switch after the credit keeps the rounds and the chambered round.
sv_neo_reload_experimentaldefaults to 1 while the partial-reload stack is reviewed (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293); thelast PR of the stack sets it back to 0. With the flag at 0 the Tachi behaves as on master.
How to review
weapon_tachi.txt: the three lines, asweapon_zr68c.txthas them (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293, Partial reloads 08: Keep a chambered round through a partial reload #2294).How to test
the fire mode lit (14+1).
fireempty,idle01empty). Reload: the icon is dim until the slide release, thenlit with 14 in the row.
sv_neo_reload_experimental 0(set before the map loads): master, 15 rounds, no+1.Results
Layer 11 build (this PR + neoAssets layer 11), Linux Debug,
ntre_engage_ctg, owner Tachi plus abot_mimicbot:reload: 16 (15+1) at +1.71 s, reserve 45 -> 30reload: 15 at +1.71 s, reserve 45 -> 30reloadempty: 15 with the chamber filled at the credit (+1.71 s; one tick 15 with the chamber empty, then 14+1)draw, 14+1 kept, no second reload; firesdraw, 15 keptdrawempty, clip 0, a freshreloademptyto 14+1fireempty,drawempty,idle01empty, then the autoreloademptyto 14+1match_end=True, 0 asserts; bots switched to the Tachi 9 timesToolchain
Linked Issues