Repository navigation
Partial reloads 12: Resume a Kyla reload after the cylinder is out - #2298
Closed
sunzenshen wants to merge 1 commit into
Closed
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
The Kyla script gets the reload phases from neoAssets: #base
"weapon_klya9_reload_phases.txt" and "ReloadPhases" {}. A switch after
the cylinder is out resumes with drawunloaded_reload and loads six
rounds; a switch before it cancels the reload. No ChamberedRound: the
revolver has no chamber and no cycle step, so the phase table ends at
2_load. The resume plays the new sound piece weapon_kyla.reload_load.
No code changes.
This was referenced Nov 9, 2026
sunzenshen
force-pushed
the
stack/reload-zr68c/70-tachi
branch
from
November 10, 2026 02:10
14a64f4 to
fa3bdc8
Compare
sunzenshen
force-pushed
the
stack/reload-zr68c/80-kyla
branch
from
November 10, 2026 02:10
835db95 to
c51ceab
Compare
This was referenced Nov 13, 2026
Closed
Contributor
Author
|
Closing to clear the board in favor of the PR stack of sunzenshen#34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on NeotokyoRebuild/neoAssets#184 (layer 12: the Kyla sources, its resume clip and phases file).
Partial reloads 12: resume a Kyla reload after the cylinder is out. This PR builds on layer 11 (#2297, the Tachi) and
pairs with neoAssets layer 12. Next: #2299 (13, MilSO).
The Kyla's reload visibly takes the cylinder out. With this PR, a switch after the cylinder is out no longer cancels the
reload: the next draw brings the revolver up without its cylinder and continues the reload (
drawunloaded_reload),loading 6 rounds. The phase code of layers 06-08 is generic, so this PR is data only.
#base "weapon_klya9_reload_phases.txt"and"ReloadPhases" {}, plus the sound entryweapon_kyla.reload_load. NoChamberedRound: a double-action revolver has no chamber to keep and no bolt to cycle,so there is no
+1and no cycle step.1_unload(cylinder out, f17) with the resume, and2_loadat master's ammo credit (f53, 1.767 s), so anuninterrupted reload keeps master's timing. A tactical reload discards the remaining rounds, as master does.
sv_neo_reload_experimentaldefaults to 1 while the stack is reviewed (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293); with the flag at 0 theKyla behaves as on master.
How to review
weapon_kyla.txt: the two lines and the sound entry.drawunloaded_reload.How to test
cylinder is out (about 0.6 s). Switch back: the revolver comes up without its cylinder, the new cylinder goes in,
and the gun has 6 rounds.
sv_neo_reload_experimental 0(set before the map loads): master.Results
Layer 12 build (this PR + neoAssets layer 12), Linux Debug,
ntre_engage_ctg:drawunloaded_reloadplays; 6 rounds at 1.845 s after the draw; the sound piece playsKnown: the resume (2.47 s) is 0.1 s longer than the reload (a full draw plus a 6-frame tilt at the original hand pace).
Toolchain
Linked Issues