Repository navigation
Partial reloads 13: Keep a chambered round through a MilSO reload - #2299
Closed
sunzenshen wants to merge 1 commit into
Closed
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
The MilSO script gets the reload phases from neoAssets and a chamber
slot: #base "weapon_milso_reload_phases.txt", "ReloadPhases" {} and
"ChamberedRound" "1", as the Tachi has them. The generic chamber code
then gives 12+1 after a tactical reload and 11+1 after a dry one, with
the chamber filled at the ammo credit. No code changes.
This was referenced Nov 9, 2026
sunzenshen
force-pushed
the
stack/reload-zr68c/80-kyla
branch
from
November 10, 2026 02:10
835db95 to
c51ceab
Compare
sunzenshen
force-pushed
the
stack/reload-zr68c/90-milso
branch
from
November 10, 2026 02:10
7e7bed1 to
1bd8934
Compare
This was referenced Nov 13, 2026
Closed
Contributor
Author
|
Closing to clear the board in favor of the PR stack of sunzenshen#34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on NeotokyoRebuild/neoAssets#185 (layer 13: the MilSO chamber phases file).
Partial reloads 13: add a chambered round to the MilSO. This PR builds on layer 12 (#2298, the Kyla) and pairs with
neoAssets layer 13. Next: #2300 (14, AA13).
As for the Tachi (layer 11, #2297), the generic chamber code of layer 08 (#2294) does the work: this PR adds the three
script lines and has no code changes.
#base "weapon_milso_reload_phases.txt","ReloadPhases" {},"ChamberedRound" "1", as the Tachi hasthem. The phases file has one
3_cyclerow each forreloadandreloadempty, at the ammo credit (1.667 s).The MilSO keeps its shipped reload clips and sounds whole: a tactical reload gives
12+1, a dry reload11+1.master; a switch after the credit keeps the rounds and the chambered round.
sv_neo_reload_experimentaldefaults to 1 while the partial-reload stack is reviewed (Partial reloads 06: Resume a ZR68C reload after the magazine is unloaded #2293); thelast PR of the stack sets it back to 0. With the flag at 0 the MilSO behaves as on master.
How to review
weapon_milso.txt: the three lines, asweapon_tachi.txthas them (Partial reloads 11: Keep a chambered round through a Tachi reload #2297).How to test
(11+1).
fireempty,idle01empty). Reload: the icon is dim until the slide release, thenlit with 11 in the row.
sv_neo_reload_experimental 0(set before the map loads): master, 12 rounds, no+1.Results
Layer 13 build (this PR + neoAssets layer 13), Linux Debug,
ntre_engage_ctg, owner MilSO plus abot_mimicbot:reload: 13 (12+1) at +1.64 s, reserve 36 -> 24reload: 12 at +1.64 s, reserve 36 -> 24reloadempty: 12 with the chamber filled at the credit (+1.64 s; one tick 12 with the chamber empty, then 11+1)draw, 11+1 kept, no second reload; firesdraw, 12 keptdrawempty, clip 0, a freshreloademptyto 11+1fireempty,drawempty,idle01empty, then the autoreloademptyto 11+1match_end=True, 0 asserts; bots switched to the MilSO 18 timesToolchain
Linked Issues