Repository navigation
Partial reloads 11: Add the Tachi chamber phases - #183
Closed
sunzenshen wants to merge 1 commit into
Closed
sunzenshen wants to merge 1 commit into
sunzenshen wants to merge 1 commit into
Conversation
The Tachi scene gets reload:3_cycle and reloadempty:3_cycle markers at the ammo credit (f52: the clip's end minus ReloadReadyBeforeEnd), and the export writes weapon_tachi_reload_phases.txt from them: one 3_cycle row per sequence at 1.733 s, when the chamber holds a round. A switch after the credit then keeps the chambered round instead of replaying reloadempty. The shipped reload and reloadempty play whole, with their original sound; no SMD or model changes.
This was referenced Nov 9, 2026
sunzenshen
force-pushed
the
stack/reload-zr68c/57-zr68l
branch
from
November 10, 2026 02:07
873e90e to
7b1b14a
Compare
sunzenshen
force-pushed
the
stack/reload-zr68c/70-tachi
branch
from
November 10, 2026 02:08
e09edb8 to
5e21344
Compare
This was referenced Nov 10, 2026
sunzenshen
marked this pull request as ready for review
November 10, 2026 06:39
sunzenshen
marked this pull request as draft
November 13, 2026 03:50
This was referenced Nov 13, 2026
Closed
Closed
Closed
Closed
This was referenced Nov 13, 2026
[backup] Partial reloads 20: Add the M41 family sources and its reload clips
sunzenshen/neoAssets#20
Closed
Closed
Contributor
Author
|
Closing to clear the board in favor of the PR stack of sunzenshen#27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR set adds chambered round tracking for the tachi. One quirk this PR highlights is that if animators are the ones to track the timing changes using the timeline interface of Blender as a guide, they are then responsible for adding the weapon script timings.
Demos:
tachi-tactical-keeps-chambered-round.mp4
tachi-dry-reload-chamber-at-credit.mp4
Partial reloads 11: add the Tachi chamber phases. Used by NeotokyoRebuild/neo#2297 (neo layer 11), which gives the
Tachi a chambered round (
15+1after a tactical reload).It is layer 11 of a stack and builds on #182 (10, ZR68-L), #181 (09, ZR68 family), #180 (08), #178 (07), #179 (06),
#177 (05), #196 (04), #195 (03), #194 (02) and #176 (01). Next: #184 (12, Kyla). The neo flag
sv_neo_reload_experimentalis 1 by default while the stack isreviewed.
Overview of Changes
jinrai_tachiscene gainsreload:3_cycleandreloadempty:3_cycleat f52, theammo credit (the clip's end minus the script's
ReloadReadyBeforeEnd). No new slots, no glued clips: the Tachikeeps its shipped
reloadandreloadempty, whole, with their original sound.weapon_tachi_reload_phases.txt: one3_cyclerow each forreloadandreloadempty, at 1.733 s, written bythe export from those markers.
3_cycleis when the chamber holds a round, so a switch after the credit keeps thechambered round instead of replaying
reloadempty.How to Review
viewmodels.blend: the two markers only;viewmodels_post_export.blendis rebuilt by the export (its inputdigest covers
viewmodels.blend).Checks (measured)
jinrai_tachi jinrai_zr68c jinrai_zr68lROM CHECK 4 projects, no clamped pose; the Tachi phases times written from the markers (set to 0.000 before the export, 1.733 after); no SMD or other phases file changedSEAM0.0000;PACE0 warnings on every gun; 27READYlines, as layer 10How to Test
row fills to 15/15: 15+1.
Related