Repository navigation
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
November 11, 2026 13:22
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success544 tests passing in 14 suites. Report generated by 🧪jest coverage report action from 0507d58 |
Contributor
Core coverage report
Test suite run success419 tests passing in 22 suites. Report generated by 🧪jest coverage report action from 0507d58 |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 6 of 8 of the split of #34. It moves the AWS RUM sink into the core's
/rumentry point, and the Angular/rumentry becomes a thin subclass.Changes
@absaoss-cps/ui-watchtower/rum: the RUM sink;aws-rum-webis an optional peer, loaded lazily./rumentry extends it with DI.npm run test:coveragenow fails below that.How to review
Mostly moved files (31 files). The behaviour of the sink is unchanged.
Closes #42
Part 6 of 8 of the epic #35. Stack on GitHub, merged bottom first: