Repository navigation
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
November 11, 2026 13:22
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success514 tests passing in 13 suites. Report generated by 🧪jest coverage report action from cbc5edb |
Contributor
Core coverage report
Test suite run success367 tests passing in 20 suites. Report generated by 🧪jest coverage report action from cbc5edb |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 5 of 8 of the split of #34. It moves the shell/fragment broadcast protocol into the core, and the Angular sinks, host and log provider become
@Injectablesubclasses of the core's.Changes
enabled: falsewins over a shared connection, and so doesdispose(): they send nothing, a disposed provider answers queries with[]at once, and the connection stays open for its other users.'broadcast'mode the Angular sink and log provider share one channel per injector.How to review
The wire fixture from part 1 is unchanged and still passes: every pairing of an Angular or core shell with an Angular or core fragment sends the same messages, so separately deployed shells and fragments need not upgrade together.
Closes #41
Part 5 of 8 of the epic #35. Stack on GitHub, merged bottom first: