Skip to content

refactor: move models, redaction and scenarios into the core - #47

Merged
fateeand merged 9 commits into
mainfrom
split/3-models
Nov 13, 2026
Merged

fateeand merged 9 commits into
mainfrom
split/3-models

Conversation

@fateeand

@fateeand fateeand commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Part 3 of 8 of the split of #34. It moves what was already framework-independent into the core, and re-exports it from the Angular package, so the Angular package's public API is unchanged (api:check and the type tests pass).

Changes

  • Models and types, redaction, user timings and the scenario class (UwtScenario) move to projects/ui-watchtower, with their tests.
  • The Angular package imports them from the core and re-exports them.
  • Type tests of the core's public types.

How to review

Mostly moved files: 74 files, with git showing renames. Look for edits inside moved files rather than reading them all.

Closes #39

Part 3 of 8 of the epic #35. Stack on GitHub, merged bottom first:

  1. test: add API, type and wire-protocol safety nets #45 Safety nets
  2. build: add the framework-independent core package #46 Scaffold the core
  3. refactor: move models, redaction and scenarios into the core #47 Move models, redaction and scenarios (this PR)
  4. refactor: add the framework-independent telemetry engine #48 Telemetry engine
  5. refactor: move the shell/fragment broadcast protocol into the core #49 Broadcast protocol
  6. refactor: move the AWS RUM sink into the core's rum entry point #50 RUM sink
  7. test: smoke-test the packed packages in real consumers #51 Smoke tests
  8. feat: release and publish both packages independently, with docs and logos #52 Release, docs and logos

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements
95.94% (+5.85% 🔼)
898/936
🟢 Branches
94.74% (-0.8% 🔻)
486/513
🟢 Functions
96.09% (+5.24% 🔼)
246/256
🟢 Lines
96.42% (+5.88% 🔼)
863/895
Show files with reduced coverage 🔻
St.❔
File Statements Branches Functions Lines
🟢
... / uwt-logger.service.ts
97.62% (-0.03% 🔻)
95.24% 93.33%
97.47% (-0.03% 🔻)
🟢
... / uwt-scenario-telemetry.service.ts
98.39% (-0.05% 🔻)
100% 94.74%
98.28% (-0.06% 🔻)
🟢
... / uwt-broadcast-host.service.ts
96.55% (-0.06% 🔻)
93.33% 100%
96.4% (-0.06% 🔻)

Test suite run success

591 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from e5c3648

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Core coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 86.8% 447/515
🟢 Branches 81.39% 258/317
🟢 Functions 87.5% 84/96
🟢 Lines 86.59% 439/507

Test suite run success

213 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from e5c3648

Base automatically changed from split/2-scaffold to main November 13, 2026 08:18
@fateeand
fateeand merged commit 24920b3 into main Nov 13, 2026
9 checks passed
@fateeand
fateeand deleted the split/3-models branch November 13, 2026 14:42
fateeand added a commit that referenced this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move models, redaction and scenarios into the core

2 participants