Repository navigation
test: add API, type and wire-protocol safety nets - #45
Merged
Merged
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
November 11, 2026 13:21
Contributor
Coverage report
Show new covered files 🐣
Test suite run success787 tests passing in 25 suites. Report generated by 🧪jest coverage report action from 0c4ff53 |
This was referenced Nov 11, 2026
| "format": "prettier --write \"**/*.{ts,mjs,html}\"", | ||
| "format:check": "prettier --check \"**/*.{ts,mjs,html}\"", | ||
| "typecheck": "tsc -p projects/ngx-ui-watchtower/tsconfig.lib.json --noEmit && tsc -p projects/ngx-ui-watchtower/tsconfig.spec.json --noEmit && tsc -p projects/ngx-ui-watchtower/rum/tsconfig.lib.json --noEmit && tsc -p projects/ngx-ui-watchtower/rum/tsconfig.spec.json --noEmit && ngc -p projects/ngx-ui-watchtower/type-tests/tsconfig.json && ngc -p projects/ngx-ui-watchtower/type-tests/tsconfig.augmented.json", | ||
| "api:check": "node scripts/api-snapshot.mjs", |
Collaborator
There was a problem hiding this comment.
Nit (optional): api:check doesn't rebuild, so locally it can pass against a stale dist/ (CI is fine since it builds first). Running the build inside api:check would avoid a surprise CI failure.
Collaborator
Author
There was a problem hiding this comment.
Thanks! api:check builds first now (same for api:update)
lukasmatta
reviewed
Nov 12, 2026
lukasmatta
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of 8 of the split of #34 (the framework-independent core). It adds safety nets for the Angular package as it is today, and changes none of its source.
Changes
public-api.snapshot.json,scripts/api-snapshot.mjs,npm run api:check): fails CI when an exported name, signature or type changes unintentionally.type-tests/): the typed-names registry augmented and empty, and compatibility of the public types.uwt-broadcast.wire.spec.tsplus a recorded fixture): a shell and a fragment exchange every message, and the fixture pins what goes over the channel. The later parts of this series must not change it. Stack traces and times are compared by type, so it passes on any machine.api:check, README note.How to review
No production code changes. Everything is a test, a fixture or a script.
Closes #37
Part 1 of 8 of the epic #35. Stack on GitHub, merged bottom first: