Repository navigation
build: guard against binary download failures - #13999
Merged
Merged
Conversation
…fig lint issues
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Planeshifter
removed
the
Good First PR
4 of 7 tasks
Planeshifter
marked this pull request as ready for review
August 7, 2026 05:04
kgryte
added
CI
Member
|
Thanks for addressing, @Planeshifter! |
kgryte
changed the title
Member
|
@Planeshifter Mind propagating the authentication fix to other workflows? We are still getting failures elsewhere. E.g., https://github.com/stdlib-js/stdlib/actions/runs/31304012985/job/93221313907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#869.
Description
This pull request:
lint_random_filesworkflow's EditorConfig lint step fails due to an infrastructure error (e.g., failing to download theeditorconfig-checkerbinary due to rate limiting) rather than actual lint errors. Before creating a sub-issue, the workflow now checks the captured lint output for the wrapper's definitive download-failure marker (Failed to download binary) and skips issue creation when present.GITHUB_TOKENon the EditorConfig lint step so that theeditorconfig-checkernpm wrapper authenticates its GitHub releases API request when downloading its binary, avoiding unauthenticated rate limits (the root cause of the spurious issues).Related Issues
No.
Questions
No.
Other
editorconfig-checkernpm wrapper routes every download-phase failure (HTTP errors, network errors, extraction errors) through a singleFailed to download binary:message before exiting non-zero, so matching on that one marker suffices and avoids false negatives from broader patterns.node_modulescaching (as already done inlint_changed_files.yml) so that the binary download is skipped entirely on cache hits.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, including inspecting the
editorconfig-checkerwrapper source to determine its failure behavior; the changes were reviewed and directed by myself.@stdlib-js/reviewers