Skip to content

build: guard against binary download failures #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Aug 7, 2026
Merged

build: guard against binary download failures #13999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/lint_random_files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ jobs:
id: lint-editorconfig
env:
FILES: ${{ steps.random-files.outputs.files }}

# Provide a token so that the editorconfig-checker binary download is authenticated, thus avoiding rate limiting:
GITHUB_TOKEN: ${{ github.token }}
run: |
set -o pipefail
files=$(echo "$FILES" | tr ',' ' ')
Expand All @@ -217,6 +220,12 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.STDLIB_BOT_PAT_REPO_WRITE }}
run: |
# Guard against creating spurious issues when the lint step failed due to an infrastructure error (e.g., failing to download the editorconfig-checker binary due to rate limiting) rather than actual lint errors:
if grep -q 'Failed to download binary' lint_editorconfig_errors.txt 2>/dev/null; then
echo 'EditorConfig lint step failed due to an infrastructure error (e.g., failed binary download). Skipping issue creation.'
exit 0
fi

strip_ansi() {
sed -r 's/\x1B\[[0-9;]*[mK]//g'
}
Expand Down