Repository navigation
build: cache node modules to avoid repeated editorconfig-checker downloads - #14000
Merged
Merged
Conversation
…loads
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
kgryte
force-pushed
the
philipp/cache-editorconfig-checker-binary
branch
from
August 7, 2026 06:23
409476b to
87a493e
Compare
kgryte
approved these changes
Aug 7, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
Let's hope this works! This is a continuous pain point, so I'll be glad to see it go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
node_modulesin thelint_random_filesworkflow (mirroring the existing setup inlint_changed_files.yml) so that, on cache hits, dependency installation — and, in particular, theeditorconfig-checkerbinary download — is skipped entirely, further reducing exposure to download failures and speeding up the daily run.Related Issues
No.
Questions
No.
Other
editorconfig-checkernpm wrapper downloads its Go binary into the package directory insidenode_moduleson first invocation, so cachingnode_modulesafter the EditorConfig lint step also caches the binary.if: always()so that the binary is cached even when the lint step fails due to lint errors.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, mirroring the existing caching setup in
lint_changed_files.yml; the changes were reviewed and directed by myself.@stdlib-js/reviewers