Skip to content

build: cache node modules to avoid repeated editorconfig-checker downloads - #14000

Merged
kgryte merged 1 commit into
developfrom
philipp/cache-editorconfig-checker-binary
Aug 7, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/cache-editorconfig-checker-binary

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • caches node_modules in the lint_random_files workflow (mirroring the existing setup in lint_changed_files.yml) so that, on cache hits, dependency installation — and, in particular, the editorconfig-checker binary download — is skipped entirely, further reducing exposure to download failures and speeding up the daily run.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • The editorconfig-checker npm wrapper downloads its Go binary into the package directory inside node_modules on first invocation, so caching node_modules after the EditorConfig lint step also caches the binary.
  • The cache save step runs with if: always() so that the binary is cached even when the lint step fails due to lint errors.
  • This PR is stacked on top of build: guard against binary download failures #13999, which guards issue creation against binary download failures and authenticates the download.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, mirroring the existing caching setup in lint_changed_files.yml; the changes were reviewed and directed by myself.


@stdlib-js/reviewers

@Planeshifter
Planeshifter marked this pull request as ready for review August 7, 2026 05:12
@Planeshifter
Planeshifter requested a review from a team August 7, 2026 05:12
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 7, 2026
@stdlib-js stdlib-js deleted a comment from stdlib-bot Aug 7, 2026
@Planeshifter
Planeshifter requested a review from kgryte August 7, 2026 05:13
Base automatically changed from philipp/fix-editorconfig-lint-guard to develop August 7, 2026 06:23
…loads

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte
kgryte force-pushed the philipp/cache-editorconfig-checker-binary branch from 409476b to 87a493e Compare August 7, 2026 06:23
@kgryte kgryte added CI Issue or pull request specific to continuous integration environments. and removed Needs Review A pull request which needs code review. labels Aug 7, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope this works! This is a continuous pain point, so I'll be glad to see it go away.

@kgryte
kgryte merged commit 079d24c into develop Aug 7, 2026
28 checks passed
@kgryte
kgryte deleted the philipp/cache-editorconfig-checker-binary branch August 7, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Issue or pull request specific to continuous integration environments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants