Skip to content

feat: add lapack/base/dlaruv - #12443

Merged
kgryte merged 11 commits into
stdlib-js:developfrom
iampratik13:lapack/dlaruv
Aug 2, 2026
Merged

kgryte merged 11 commits into
stdlib-js:developfrom
iampratik13:lapack/dlaruv

Conversation

@iampratik13

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: passed
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add lapack/base/dlaruv

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@iampratik13
iampratik13 requested a review from a team June 2, 2026 11:59
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 2, 2026
@stdlib-bot

stdlib-bot commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dlaruv $\\color{green}438/438$
$\\color{green}+0.00\\%$
$\\color{green}12/12$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}438/438$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@iampratik13 iampratik13 added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels Jun 2, 2026
@iampratik13

Copy link
Copy Markdown
Member Author

Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/benchmark/benchmark.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/benchmark/benchmark.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/benchmark/benchmark.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/benchmark/benchmark.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/docs/repl.txt Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/docs/repl.txt Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/examples/index.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/base.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/base.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/dlaruv.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/dlaruv.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/dlaruv.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/ndarray.js Outdated

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@iampratik13
iampratik13 marked this pull request as draft June 14, 2026 19:22
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@iampratik13
iampratik13 marked this pull request as ready for review June 23, 2026 07:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 23, 2026
@iampratik13 iampratik13 removed the Needs Changes Pull request which needs changes before being merged. label Jun 23, 2026
@iampratik13 iampratik13 mentioned this pull request Jun 24, 2026
3 of 7 tasks
anandkaranubc and others added 2 commits August 1, 2026 01:25
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc

Copy link
Copy Markdown
Contributor

@iampratik13 I updated the PR with some changes, based on the recent review. Can you please check those and confirm if everything looks good?

@iampratik13

Copy link
Copy Markdown
Member Author

@anandkaranubc Yes, it looks good to me. Thanks for the improvements!

@anandkaranubc
anandkaranubc requested a review from kgryte August 1, 2026 20:49
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/benchmark/benchmark.ndarray.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/docs/types/index.d.ts Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/docs/repl.txt Outdated
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/docs/repl.txt Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/lapack/base/dlaruv/lib/ndarray.js Outdated
kgryte added 2 commits August 1, 2026 18:57
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Only thing left is adding a reference citation which I will do later this evening after I add to the project's citation database.


The function has the following parameters:

- **seed**: [`Int32Array`][@stdlib/array/int32] seed array of four integers. Each element must be between `0` and `4095`, and `seed[3]` must be odd. On exit, the seed is updated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is likely fine to have this be an Int32Array, especially given the range of desired seed values. There is some mild concern that this should be the same as CBLAS_INT (which could be either int64 or int32 depending). We can revisit once we add the C implementation.

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added review: 2 and removed Needs Review A pull request which needs code review. labels Aug 2, 2026
@kgryte
kgryte merged commit 3a169fa into stdlib-js:develop Aug 2, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). review: 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants