Repository navigation
Conversation
…dependency-modernization
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
🦋 Changeset is good to goLatest commit: 477b04f We got this. Not sure what this means? Click here to learn what changesets are. |
| contents, | ||
| }; | ||
| try { | ||
| const contents = readFileSync(fullPath).toString("base64"); |
There was a problem hiding this comment.
we may want to remove / check for double quotes here. in the porcelain with all untracked files, we can have something like:
git status --porcelain --untracked-files=all
?? "new dir/file.txt"
which means file have a double quote. in the readFileSync that can fail, because there is no file named '"new dir/file.txt"'
| with: | ||
| package-json-directory: ${{ inputs.contracts_directory }} | ||
| pnpm-version: ^10.0.0 | ||
| pnpm-version: ^12.0.0 |
There was a problem hiding this comment.
as this is a reusable workflow, can we make this similar to reusable-docusaurus?
We have a lot of ancient packages and dependencies in this repo that were causing lots of security alerts. Figured we'd do a full sweep.
Overview
Comprehensive modernization of runtime engines, build tooling, testing framework, GitHub Actions SDKs, and application dependencies across the monorepo. This upgrade targets Node 26 and pnpm 12, migrates Nx to 23.3, transitions ESLint to Flat Config (
eslint.config.mjs), upgrades Vitest to 5.0, and updates all@actions/*SDKs to their latest major releases.Package Upgrades
Runtimes & Engines
nodejs24.14.126.10.0.tool-versionspnpm10.6.5/^10.0.012.9.1/^12.0.0.tool-versions,package.json, CI workflows, composite actionsMonorepo Tooling & Transpilation
nx22.7.1223.3.0@nx/devkit22.7.1223.3.0@nx/esbuild22.7.1223.3.0@nx/eslint22.7.1223.3.0@nx/eslint-plugin22.7.1223.3.0@nx/js22.7.1223.3.0@nx/plugin22.7.1223.3.0esbuild^0.23.1^0.28.2apps/update-action-versions@swc-node/register1.11.11.12.1@swc/cli0.7.100.8.1@swc/core1.15.81.16.13@swc/helpers0.5.190.5.23Linting & Formatting (Flat Config Migration)
eslint^8.57.19.39.5.eslintrc.jsontoeslint.config.mjs@typescript-eslint/eslint-plugin^7.18.08.71.1@typescript-eslint/parser^7.18.08.71.1@eslint/eslintrc^3.0.0@eslint/js^9.8.0jsonc-eslint-parser^3.3.0typescript-eslint^8.58.0prettier^2.8.8^3.9.9actions/signed-commitsTesting & Types
vitest^4.1.11^5.0.3typescript5.9.3^6.0.3@types/node24.12.2/^24.13.6^26.6.4GitHub Actions SDKs & Octokit
@actions/core^2.0.3^3.0.1@actions/github^8.0.1^9.1.1@actions/artifact^5.0.3/^6.2.1^6.3.1@actions/cache^5.2.0^6.3.0apps/go-conditional-tests@actions/exec^1.1.1^3.0.0actions/signed-commits@actions/glob^0.5.1^0.7.0@octokit/types^16.0.0^18.0.0octokit^3.2.2^5.0.5apps/actions-dependencies-updaterApplication Dependencies
p-limit^6.2.0^7.3.3apps/go-conditional-testsjira.js^4.1.3^6.3.0libs/jira-tracingdiff^8.0.4^9.0.0actions/apidiff-goreplace-in-file^7.2.0^9.0.0apps/update-action-versionsdotenv^16.6.1^18.0.6apps/actions-dependencies-updaterKey Highlights & Architectural Changes
Node 26 & pnpm 12 Engines:
26.10.0and pnpm12.9.1.pull-request-main.yml,push-main.yml,solidity-review-artifacts.yml,reusable-docusaurus.yml) and composite actions (setup-nodejs,cicd-build-publish-artifacts-ts,ci-lint-ts,ci-test-sol,ci-test-ts,cicd-changesets) topnpm-version: "^12.0.0".overridesandallowBuildsintopnpm-workspace.yamlconforming to pnpm 12 standards.ESLint 9 Flat Config Migration:
.eslintrc.jsonconfigurations into modulareslint.config.mjsfiles in root and configured subprojects.nx.jsonmatching baseline.ESM Compatibility for Actions SDKs:
vi.mock("@actions/core"),vi.mock("@actions/github")) to accommodate non-configurable exports in native ESM@actions/*v3/v9 modules.Git Attributes & Diff Optimization:
**/dist/**and**/out/**with-diff merge=binaryin.gitattributesto prevent massive 30,000+ line text diffs from stalling git CLI and editor status watchers..zed/settings.jsonfile scan exclusions.Merge Danger
@v1tags for all composite actions, silently switching every consumer to pnpm 12 defaults