feat(config): tsx, bundler resolution, verbatimModuleSyntax, noUncheckedIndexedAccess by kalverra · Pull Request #1693 · smartcontractkit/.github

kalverra · 2026-10-08T19:45:21Z

Executes the remaining phases of the TS standards modernization plan (follow-up to #1688). Refs DX-5569. Plan: .agents/local/plans/update-ts-standards.md.

A3 — ts-node → tsx (+ ESM packaging)

All ts-node script invocations swapped to tsx; actions-dependencies-updater drops deprecated node --loader ts-node/esm.
"type": "module" on go-conditional-tests, go-mod-validator, update-action-versions; bundled CJS entrypoints renamed .cjs (dist/index.cjs, out/index.cjs) so node doesn't misread them as ESM. action.yaml main paths updated; dists rebuilt.
generate-gomod-fixtures.ts fixed for real ESM execution (default-import fs-extra, node:fs, import.meta.dirname).
Removed ts-node, @swc-node/register, @eslint/eslintrc devDeps.

B1 — Resolution + target

tsconfig.base.json: moduleResolution: "bundler", module: "esnext", target: "es2023"; deprecated baseUrl removed (paths made tsconfig-relative); ignoreDeprecations dropped from all 22 tsconfigs.
Exceptions: nx-chainlink (tsc → CJS dist) on nodenext/nodenext with explicit .js extensions ("type": "commonjs" keeps CJS emit); actions-dependencies-updater node16 → nodenext.

B2 — verbatimModuleSyntax

Enabled in base; esbuild/vite honor it. Mechanical import type fixes across actions/apps/libs, enforced by consistent-type-imports eslint rule (.mts now lint-covered). Types-only packages no longer load at runtime.

C1 — noUncheckedIndexedAccess

Enabled in base. ~50 reviewed null-handling fixes across adu, go-mod-validator, go-conditional-tests, update-action-versions, jira-tracing, signed-commits tests. Guards preserve behavior; malformed inputs now fail fast with clear errors instead of undefined propagation.

Deferred per plan: exactOptionalPropertyTypes (C2), ESM-first monorepo.

Validation

pnpm nx run-many -t build test lint 58/58 green after each phase.
Per-project tsc scratch typecheck: zero new errors vs baseline at every phase (all remaining errors are pre-existing latent — no tsc gate in CI).
Dist diffs audited line-by-line; smoke-runs of rebuilt actions (node dist/index.cjs) green; fixtures:gomods end-to-end; dists rebuilt and committed (covered by the pending dependency-modernization changeset).

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

github-actions · 2026-10-08T19:45:45Z

🦋 Changeset is good to go

Latest commit: 0c9b55a

We got this.

Not sure what this means? Click here to learn what changesets are.

chainchad

Each action that gets modified should get its own changeset - either a dedicated file or one changeset for all of the modified packages.

tvc-robsondebraga · 2026-10-14T19:15:23Z

  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
-    "module": "commonjs",
+    "module": "nodenext",


module changes like this can have deep changes. wonder how was the validation done and/or will it change current compilation

tvc-robsondebraga · 2026-10-14T19:18:23Z

-      description: "Run shellcheck"
+  jobs:
+    - name: betterleaks
+      run: betterleaks git . --pre-commit --staged -v


do we want to add this to .tool-versions (https://github.com/smartcontractkit/.github/blob/main/.tool-versions) ?

tvc-robsondebraga · 2026-10-14T19:23:23Z

        "main": "apps/go-conditional-tests/src/index.ts",
        "assets": [],
-        "outputFileName": "index.js",
+        "outputFileName": "index.cjs",


do we ingest this file somewhere else? I checked and did not found updates. Can we double check?

…pe:module packages - Swap all ts-node script invocations to tsx (actions-dependencies-updater start drops deprecated node --loader ts-node/esm flag). - Add "type": "module" to go-conditional-tests, go-mod-validator, update-action-versions; rename bundled CJS entrypoints to .cjs (dist/index.cjs, out/index.cjs) so node doesn't misread them as ESM. action.yaml main paths updated; dists rebuilt. - Fix generate-gomod-fixtures.ts for real ESM execution: default-import fs-extra (named CJS re-exports not statically detectable), read/write from node:fs, import.meta.dirname. - Remove ts-node, @swc-node/register, @eslint/eslintrc devDeps. - Fix SC2155 shellcheck warnings in go-mod-validator test.sh. Validation: nx run-many lint/test green; fixtures:gomods end-to-end run; local/start scripts smoke-run; node dist/index.cjs smoke green. Refs DX-5569

… drop ignoreDeprecations - tsconfig.base.json: moduleResolution bundler + module esnext (matches esbuild semantics), target es2023. Remove deprecated baseUrl (TS5101 under TS 6); paths made tsconfig-relative. - Remove ignoreDeprecations "6.0" from all tsconfigs (node10 resolution and baseUrl deprecations gone with the switch). - Exceptions: - libs/nx-chainlink (tsc -> CJS dist): module/moduleResolution nodenext; package "type": "commonjs" keeps CJS emit. Explicit .js extensions added to relative imports. - apps/actions-dependencies-updater: node16 -> nodenext (module + moduleResolution), target es2023; sources already use explicit .mjs extensions. - actions/*: standalone configs set esnext + bundler. - Rebuilt dists: codeowners-review-analysis, gha-workflow-validator (es2022+ native class-field emit; behavior-identical). Validation: nx run-many build/test/lint 58/58 green; per-project tsc scratch typecheck vs baseline — zero new errors (all remaining are pre-existing latent, no tsc gate in CI); nx-chainlink tsc dist still CJS; dist smoke-runs green. Refs DX-5569

- tsconfig.base.json: verbatimModuleSyntax true (B1 made this safe; esbuild and vite honor it). - eslint.config.mjs: enforce @typescript-eslint/consistent-type-imports (separate-type-imports fixStyle, import() type annotations allowed); *.mts now covered by the TS lint blocks. - Mechanical fixes across actions/apps/libs: type-only imports marked import type (types-only packages like @octokit/types no longer load at runtime under vite/vitest; esbuild no longer needs auto-elision). - apps/actions-dependencies-updater: .mts sources and generated types use import type/export type. - Remove fully unused 'import * as semver' in apidiff-go util.ts (verbatim semantics would otherwise preserve and bundle it). - Signed-commits/apidiff-go/codeowners-review-analysis dists rebuilt (let->const and import cleanup; behavior-identical). Validation: nx run-many build/test/lint 58/58 green; per-project tsc scratch typecheck — zero new errors vs B1 baseline; dist diffs audited line-by-line. Refs DX-5569

…fixes - tsconfig.base.json: noUncheckedIndexedAccess true. - actions-dependencies-updater: guards for cache lookups (caches/github), tag parsing fallbacks (utils), extractDetailsFromActionIdentifier returns undefined for malformed identifiers instead of undefined fields, yaml file destructure guard, skip dependencies without pinned ref, ref params loosened where undefined already flowed at runtime. - go-mod-validator: deps line-cache local capture, owner/repo defaults (guaranteed by depPrefix filter), git hunk header guard, cache lookups via undefined-check instead of 'in', getDefaultBranch throws clear error when default_branch missing, rest[0] fallback. - go-conditional-tests: hash via Object.entries (no re-index), package line destructure with malformed-line skip, duplicate-check via local. - update-action-versions: tag split defaults, action map entry guards, wm[file] ?? [] iteration. - jira-tracing: changeset file capture with clear error when missing, first-issue guards. - signed-commits: repo-tags test args optional chaining. - Dists rebuilt for the three source-touched apps. Validation: nx run-many build/test/lint 58/58 green; per-project tsc scratch typecheck — all projects at or below pre-C1 baseline; each fix reviewed for behavior preservation. Refs DX-5569

Prior dist in 9af18f5 was built before the prettier --write pass; rebuild so committed artifacts match a fresh build (artifact-diff CI). Refs DX-5569

Auto-fixed by local lefthook gofumpt hook (blank lines, func spacing, EOF newlines). Refs DX-5569

…push - pre-commit: new code-lint command (eslint --fix then prettier --write on staged js/ts/mts files, dist/out excluded, auto-staged). Previously staged code files got no eslint or prettier fixes. - prettier now invoked directly on staged files (pnpm prettier:write {staged_files} unioned with the script's repo-wide glob, formatting the whole tree every commit); glob extended to js/ts code files via code-lint. - Fixers run sequentially before build-artifacts (was parallel: builds raced the fixers and committed stale dist bytes). - build-artifacts and code-lint exclude dist/out bundles. - New pre-push hook: pnpm test:affected (short, ~15s) gated on pushed code files. - gitignore lefthook-local.yml (local extends, untracked). Refs DX-5569

kalverra added this pull request to stack #1694 October 8, 2026 19:45

kalverra changed the title ~~DX 5569/dev execution~~ feat(config): tsx, bundler resolution, verbatimModuleSyntax, noUncheckedIndexedAccess Oct 8, 2026

kalverra marked this pull request as ready for review October 8, 2026 20:16

kalverra requested a review from a team as a code owner October 8, 2026 20:16

product-security-plaid-production Bot requested a review from chainchad October 8, 2026 20:16

kalverra force-pushed the DX-5569/dev-execution branch from 1ae50ed to 9312fef Compare October 8, 2026 20:53

chainchad reviewed Oct 8, 2026

View reviewed changes

tvc-robsondebraga requested changes Oct 14, 2026

View reviewed changes

kalverra added 10 commits October 14, 2026 16:47

build: rebuild go-conditional-tests dist from formatted source

c24f0e7

Prior dist in 9af18f5 was built before the prettier --write pass; rebuild so committed artifacts match a fresh build (artifact-diff CI). Refs DX-5569

style: gofumpt formatting

62aaace

Auto-fixed by local lefthook gofumpt hook (blank lines, func spacing, EOF newlines). Refs DX-5569

fix: pre-commit flow

cfb9eac

fix: stage fixed

28c1ad4

chore(changeset): add changeset for tsx/ESM/strictness migration

4678d66

kalverra force-pushed the DX-5569/dev-execution branch from f563684 to 4678d66 Compare October 14, 2026 20:54

kalverra closed this Oct 15, 2026

Navigation Menu

Repository navigation

feat(config): tsx, bundler resolution, verbatimModuleSyntax, noUncheckedIndexedAccess - #1693

feat(config): tsx, bundler resolution, verbatimModuleSyntax, noUncheckedIndexedAccess#1693
kalverra wants to merge 10 commits into
DX-5569/config-hygienefrom
DX-5569/dev-execution

kalverra commented Oct 8, 2026 •

edited by atlassian Bot

Loading

Uh oh!

github-actions Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

chainchad left a comment

Uh oh!

tvc-robsondebraga Oct 14, 2026

Uh oh!

tvc-robsondebraga Oct 14, 2026

Uh oh!

tvc-robsondebraga Oct 14, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kalverra commented Oct 8, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

A3 — ts-node → tsx (+ ESM packaging)

B1 — Resolution + target

B2 — verbatimModuleSyntax

C1 — noUncheckedIndexedAccess

Validation

Uh oh!

github-actions Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset is good to go

Uh oh!

chainchad left a comment

Choose a reason for hiding this comment

Uh oh!

tvc-robsondebraga Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

tvc-robsondebraga Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

tvc-robsondebraga Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kalverra commented Oct 8, 2026 •

edited by atlassian Bot

Loading

github-actions Bot commented Oct 8, 2026 •

edited

Loading