Skip to content

feat(config): TS config hygiene — drop decorator flags, native-flat ESLint, slim jira-tracing tsconfig - #1692

Closed
kalverra wants to merge 2 commits into
feat/dependency-modernizationfrom
DX-5569/config-hygiene
Closed

kalverra wants to merge 2 commits into
feat/dependency-modernizationfrom
DX-5569/config-hygiene

Conversation

@kalverra

@kalverra kalverra commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Phase A of the TS standards modernization plan (follow-up to #1688). Refs DX-5569.

  • Remove experimentalDecorators/emitDecoratorMetadata from tsconfig.base.json (no decorators in source).
  • Rewrite root eslint.config.mjs as native flat config: eslint-config-prettier imported directly, tseslint.config() helper, @eslint/js recommended scoped to JS files, tseslint recommended for TS, jsonc-eslint-parser inline. No FlatCompat; @eslint/eslintrc devDep removed.
  • Fix code surfaced by stricter tseslint recommended severities: unused vars and explicit anys in go-mod-validator/go-conditional-tests tests.
  • Slim libs/jira-tracing/tsconfig.json (110-line tsc --init template) to extends-base + project specifics.

Validation: nx run-many lint/build/test 58/58 green; prettier check clean.

Stack created with GitHub Stacks CLI • Give Feedback 💬

…SLint, slim jira-tracing tsconfig

- Remove experimentalDecorators/emitDecoratorMetadata from tsconfig.base.json
  (no decorators in source).
- Rewrite root eslint.config.mjs as native flat config: eslint-config-prettier
  imported directly, tseslint.config() helper, @eslint/js recommended scoped
  to JS files, tseslint recommended for TS, jsonc-eslint-parser inline. No
  FlatCompat; @eslint/eslintrc devDep removed.
- Fix code surfaced by stricter tseslint recommended severities: unused vars
  (skip-position destructuring, unused imports) and explicit anys in
  go-mod-validator/go-conditional-tests tests (vi.mocked, typed fixtures).
- Slim libs/jira-tracing/tsconfig.json (110-line tsc --init template) to
  extends-base + project specifics.

Validation: nx run-many lint/build/test 58/58 green; prettier check clean.

Refs DX-5569
@kalverra
kalverra added this pull request to stack #1694 October 8, 2026 19:45
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🦋 Changeset is good to go

Latest commit: 047193e

We got this.

Not sure what this means? Click here to learn what changesets are.

@kalverra
kalverra marked this pull request as ready for review October 8, 2026 20:16
@kalverra
kalverra requested a review from a team as a code owner October 8, 2026 20:16
// "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */

/* Language and Environment */
"target": "ES2022" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check what is default target? this is not exposed in extends file, which could mean a different target.

@kalverra kalverra closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants