Repository navigation
fix: raise unsafe property changes across assemblies - #177
Open
ChrisPulman wants to merge 2 commits into
Open
ChrisPulman wants to merge 2 commits into
ChrisPulman wants to merge 2 commits into
Conversation
- Resolve ReactiveUI notification extensions from the owner and base assemblies. - Support both runtime flavours and retain the legacy interface assembly fallback. - Cover split assemblies, notification ordering, and fallback raise methods. - Exercise ToPropertyUnsafe with ReactiveUI in the verification example. Closes #176
- Update the central RoslynCommonAnalyzers version for existing analyzer packages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 99.28% 99.32% +0.04%
==========================================
Files 403 403
Lines 15033 15041 +8
Branches 2229 2232 +3
==========================================
+ Hits 14925 14940 +15
+ Misses 108 101 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This was referenced Oct 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToPropertyUnsafenow raises notifications when ReactiveUI's interface and extension methods live in separate assemblies.Why
ReactiveUI 26.0.1 defines
IReactiveObjectinReactiveUI.Coreand its notification extensions inReactiveUIorReactiveUI.Reactive. Looking only in the interface assembly causesToPropertyUnsafeto fail for a ReactiveObject view model.Closes #176.
Breaking changes
None.
How this was verified
Regression tests cover both runtime flavours, separate interface/extension assemblies, consumer subclasses, legacy layouts, optional before-change notifications, and void or returning raise methods. Exercised the full solution build and TUnit suite, all configured ToProperty verification targets, documentation examples, and Windows platform/threading examples; the modified runtime file has complete line and branch coverage.
Native AOT compilation reached native linking, which could not complete because this host lacks Windows SDK libraries (
advapi32.lib). Linux and Apple execution were unavailable on this Windows host.Notes for the reviewer
Start with the notification extension lookup: the owner's inheritance chain identifies the ReactiveUI flavour that holds notification state. The tests create separate assemblies without adding dependencies; the analyser version update is in a separate commit. The sibling ReactiveUI solution and other unsafe APIs did not need changes.
Checklist