Repository navigation
fix: follow ViewModel inherited from referenced assemblies - #180
Merged
Merged
Conversation
- Capture the inherited public ViewModel metadata used by interaction bindings. - Reuse property notification inspection and preserve member hiding and weakly typed fallback. - Test referenced generic view bases, late assignment, replacement, clearing, and disposal in both runtime flavours. - Verify related property and command bindings and C# 7.3 generated output. - Demonstrate activation-time binding and retain the shared en-US test culture. Closes #170
4 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 403 403
Lines 15033 15035 +2
Branches 2229 2230 +1
=======================================
+ Hits 14925 14927 +2
Misses 108 108 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
glennawatson
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated interaction bindings follow a public typed ViewModel inherited from a referenced generic view base. Late assignment, replacement, clearing, and disposal now preserve the expected handler lifetime.
Why
Closes #170. External view bases were omitted from the property metadata used to observe ViewModel replacement.
Breaking changes
None.
How this was verified
Exercised real referenced assemblies with task and observable handlers, initially absent and present view models, replacement, clearing, disposal, both runtime flavours, related property and command bindings, and C# 7.3 generated output. Ran the full solution with coverage, a warnings-as-errors build, and all available managed examples. The changed generator file has complete line and branch coverage. Ordinary tests use a common en-US culture, with explicit culture regressions retaining their overrides.
Published and ran the Windows x64 native AOT example using the installed Windows SDK and Visual Studio Enterprise C++ toolchain, with no trim or AOT warnings. Linux and Apple host verification was unavailable.
Notes for the reviewer
The fix projects only the inherited ViewModel property through the existing symbol and notification inspection. General referenced-base scanning remains bounded. This branch is independent of the production fixes in #177 and #179. Companion website PR #1006 documents the activation-time example.
Checklist