Repository navigation
Fix navigation and donation fallbacks for partial translations - #364
Merged
Merged
Conversation
Deploying organicmaps with
|
| Latest commit: |
e7dc34b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://887f9aa2.organicmaps.pages.dev |
| Branch Preview URL: | https://fix-partial-language-menu-fa.organicmaps.pages.dev |
biodranik
force-pushed
the
fix/partial-language-menu-fallback
branch
from
November 3, 2026 14:16
587eef9 to
10b8d7b
Compare
biodranik
changed the title
Signed-off-by: Alexander Borsuk <me@alex.bio>
Resolve menu destinations in the active language, then use strict lookups for the default-language fallback. This avoids scanning translation lists and reloading available translations. Load donation companion pages from the default language before selecting a translation, so either landing page can be translated independently. Cover both missing companions with production donation templates and assert the selected form label and generated destination. Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
fix/partial-language-menu-fallback
branch
from
November 3, 2026 16:57
95d5de5 to
e7dc34b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A language can provide a homepage without translating every navigation destination. Resolve News, Donate, Contribute and Help directly in the active language, then use a strict default-language lookup for each missing destination. Available translations keep their own labels and URLs, while missing required default resources still stop the build.
The donation pages can also be translated independently. Load their companion pages explicitly from the default language before selecting an available translation: the main page can use default-language checkout labels, and the focused subscribe page can link to the default-language donation page.
The Zola regression suite covers six menu configurations and both missing donation companions, checking the selected labels and generated destinations. Shared fixture writing and build helpers keep the tests small. Run the suite in the Zola CI job with the same pinned version as the site build.
Validation:
npm test: 24 tooling tests and 185 round-trip checks pass.npm run test:browser: all eight checkout regressions pass.git diff --check masterpasses.Related to #363; these fallback fixes are independent of the Korean translation and the metadata-validation fix in #365.