Skip to content

Declare source languages for navigation and donation fallbacks - #369

Open
biodranik wants to merge 10 commits into
masterfrom
fix/partial-language-menu-fallback
Open

biodranik wants to merge 10 commits into
masterfrom
fix/partial-language-menu-fallback

Conversation

@biodranik

@biodranik biodranik commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Partial translations can mix fallback text with the page’s language. Declare source languages for navigation and checkout text, and let the donation card detect its own direction. Payment return URLs keep the page language.

Resolve footer translations and donation companions directly with default-language fallbacks. Use root-relative navigation paths and complete source filenames so checkout directory names and translated slugs cannot break footer lookups. Correct native language names, installation-label brands and translation guidance.

Validation: five Zola regression methods, 25 tooling tests, 185 round-trip checks and eight mocked browser tests pass. Full builds preserve all 4,015 HTML paths; all 3,158 checked navigation destinations resolve.

Follow-up to #364; related to #363 and #368.

@biodranik
biodranik requested a review from vng November 3, 2026 18:01
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Deploying organicmaps with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb79db4
Status: ✅  Deploy successful!
Preview URL: https://5bbb6d85.organicmaps.pages.dev
Branch Preview URL: https://fix-partial-language-menu-fa.organicmaps.pages.dev

View logs

Declare fallback menu labels and checkout text in their source language while
retaining the donation page language for payment return URLs. Resolve donation
companions directly in the active language with a strict default-language
fallback, and use full resources' root-relative paths for internal links.

Exercise the real checkout form with translated companions and slugs, missing
default resources, inherited menu, heading and form languages, and an independent
payment language. Document the lookup rules and regression command.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Detect direction from the checkout labels so an English fallback stays left-to-right inside an RTL document. Cover the rendered English card in an Arabic page and preserve the native Arabic form direction.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Mark fallback footer labels and both language-selector branches with the language of their text. Exercise mixed footer translations and both selector sources in rendered multilingual fixtures.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Cover valid, missing, duplicate and reordered donation markers with the Python build helper. Keep browser regressions focused on rendered checkout behavior, and document the test prerequisites in CI and contributor guidance.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Translate reader-facing titles and descriptions while preserving published slugs and aliases. State the existing-target requirement once for localized Markdown links.

Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik
biodranik force-pushed the fix/partial-language-menu-fallback branch from 43da96f to c17ae48 Compare November 4, 2026 13:18
Keep the Arabic card wrapper when exercising English labels, and assert that the payment language remains Arabic. The direction assertions catch a card incorrectly configured from the surrounding page language.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Build selector links and automatic redirects from resource translations. Remove unused taxonomy translation inputs and keep the multilingual fixture focused on generated resource links and their label languages.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Show Nederlands and Galego in language navigation so each name matches its declared language. Keep Organic Maps and Google Play unchanged in Galician, Hindi, Indonesian, Marathi and Occitan installation labels. Explain that the selector's language key contains the language's own name.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Use the default-language inventory's relative source paths for localized page and section lookups, retaining the default resource when a translation is absent. Classify resources by their complete source filename so checkout directory names and translated URL slugs cannot affect lookup.

Use full resource paths for navigation and declare the API tooltip's English language. Exercise mixed translation availability, an ordinary page with _index in its filename and a translated slug, and a checkout directory containing _index.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Describe structural fingerprints in terms of blank-line-separated blocks while keeping one paragraph per line for readable diffs and CJK rendering. Explain the current preview-image path rule.

Align Ukrainian bookmark terminology with the glossary, document DeepL's supported formality options, and explain the current polite-address conventions.

Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik
biodranik force-pushed the fix/partial-language-menu-fallback branch from fabbfef to fb79db4 Compare November 4, 2026 16:10
@biodranik
biodranik requested review from vng and removed request for vng November 5, 2026 01:32

This branch was successfully deployed

1 active deployment
production — fb79db4e Deployed Nov 4, 2026 by biodranik via Check Zola build #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant