Repository navigation
Validate FAQ metadata before skipping section notes - #365
Merged
Merged
Conversation
Deploying organicmaps with
|
| Latest commit: |
2bca0d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7588440.organicmaps.pages.dev |
| Branch Preview URL: | https://fix-faq-frontmatter-validati.organicmaps.pages.dev |
Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
fix/faq-frontmatter-validation
branch
from
November 3, 2026 14:19
a44e777 to
1f40cfe
Compare
Signed-off-by: Alexander Borsuk <me@alex.bio>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FAQ section bodies contain an unrendered maintenance note, while their titles, descriptions and menu labels are visible to readers. Validate reader-visible metadata before applying the body exemption, reuse the parsed English metadata, and check unchanged strings and runtime placeholders in one field loop.
The regression covers copied English metadata, translated metadata with the unchanged note, incorrect register, and valid and stale source-wording exemptions. A stale exemption must produce an ERROR. Hook and contributor documentation describe staged validation and paragraph-based fingerprints.
Validation:
npm testpasses 25 tooling tests and 185 round-trip checks; all 3,169 corpus files round-trip.sh -n .githooks/pre-commit, andgit diff --checkpass.Related to #363 and #364's independent navigation and donation fallback fixes. #368 adds required-field, parser, product-name and rendering-policy validation on a separate branch from master.