Repository navigation
[i18n/korean]: Add New Translation Language, Korean - #363
channel101 wants to merge 2 commits into
Conversation
Signed-off-by: channel101 <202932523+channel101@users.noreply.github.com>
5f053b2 to
7b2caa5
Compare
|
force push was held due to commit signing |
Signed-off-by: channel101 <202932523+channel101@users.noreply.github.com>
biodranik
left a comment
biodranik
left a comment
There was a problem hiding this comment.
Reviewed both commits and all six changed files, including the affected navigation/templates and translation tooling. The current CI run, local Zola build and offline tooling tests pass. The inline findings below cover issues introduced by this PR; the missing Korean news/FAQ destinations and the donation link's switch to English were also reproduced in a browser.
| @@ -0,0 +1,10 @@ | |||
| --- | |||
| render: false | |||
There was a problem hiding this comment.
[P1] Generate working News and Help destinations before advertising them
Both this section and content/faq/_index.ko.md have render: false, and there are no Korean posts/questions to generate their taxonomy pages. The build succeeds but emits neither /ko/news/index.html nor /ko/faq/index.html. Both the Korean main menu and the English pages' language links advertise those URLs. In a fresh ko-KR browser, opening /news/ or /faq/ automatically redirects to the missing Korean destination and produces a 404.
For News, a validated option is to render this section and set render = false on the Korean news taxonomy, as Japanese already does; the existing list template can display English articles as fallback. For an untranslated FAQ, keep the destination in English until Korean content exists. Merely removing the section stubs currently exposes a separate pre-existing menu fallback bug, which will need fixing if taking that approach.
| @@ -0,0 +1,29 @@ | |||
| --- | |||
| title: Support the development of Organic Maps | |||
There was a problem hiding this comment.
[P2] Publish actual translations instead of English copies labeled Korean
This entire file and content/donate/index.ko.md exactly match their English sources, including title, description and extra.menu_title. They are nevertheless advertised as Korean translations and rendered with lang="ko". The homepage also retains its English H1, most sponsor descriptions, and the Community section. The draft description already acknowledges incomplete translation; these are the remaining reader-visible sections to finish before merging. Alternatively, omit untranslated pages and use English fallback navigation rather than duplicate English content under Korean URLs.
|
|
||
| **Organic Maps** 은 모든 기능이 100% 인터넷 연결 없이 지원하는 몇 안 되는 애플리케이션 중 하나입니다. Organic Maps을 설치하고 지도를 다운로드한 뒤 SIM 카드를 던저 버리도, 네트워크에 데이터 전송 없이 배터리 한 번 충전으로 일주일간 여행할 수 있습니다. | ||
|
|
||
| > 2025년 12월에 Organic Maps 가 [앱 600만 설치 수를 달성 했습니다](@/news/2025-12-31/500/index.md). 저희가 더 발전하기 위해 [후원](@/donate/index.md) 해주세요! |
There was a problem hiding this comment.
[P2] Keep internal links in Korean when a Korean target exists
The donation link here and the second one at line 88 still use @/donate/index.md, despite index.ko.md existing. The same issue affects the contribution page's donation link and the donation page's contribution link: four links total. If those Korean pages are retained, point these links at index.ko.md.
This has an observable effect: after selecting Korean, clicking the homepage donation link lands on /donate/ with lang="en"; the stored language choice means the automatic language redirect does not correct it. The news-post link can remain English because that post has no Korean translation.
| <a href="https://nlnet.nl/"><img src="/sponsors/nlnet.svg" alt="NLnet 재단" width="200" loading="lazy" decoding="async"></a> | ||
| </td> | ||
| <td> | ||
| <a href="https://github.com/organicmaps/organicmaps/milestone/7">검색 및 글꼴 개선 프로젝트</a>가 NGI0 Entrust Fund 을 통해 <a href="https://nlnet.nl/project/OrganicMaps/">후원 했습니다.</a> <a href="https://nlnet.nl/entrust/">NGI0 Entrust Fund</a> 는 <a href="https://nlnet.nl/">NLnet Foundation</a>가 유럽연합 집행위원회의 <a href="https://www.ngi.eu/">차세대 인터넷 프로그램</a>지원 으로부터 받은 금전적 지원 기반으로 DG 통신 네트워크, 콘텐츠 및 기술의 후원 아래, 보조금 계약 번호 101069594에 따라 채결되었습니다. |
There was a problem hiding this comment.
[P2] Preserve the funding relationship in the NLnet attribution
검색 및 글꼴 개선 프로젝트가 … 후원 했습니다 makes the Search & Fonts project the sponsor, whereas the English source says it received funding through NGI0 Entrust Fund. A suitable first sentence is 검색 및 글꼴 개선 프로젝트는 NGI0 Entrust Fund의 지원을 받았습니다. with the existing links preserved.
The second sentence also needs rewriting: the source describes the fund being established by NLnet with European Commission support, while the Korean sentence ends as though an agreement/fund was concluded (채결되었습니다). Preserve the donor/recipient relationship and grant agreement number 101069594.
|
|
||
| **Organic Maps** 는 여행자, 관광객, 운전자, 등산객 및 자전거 이용자들을 위한 개인정보 보호 중심의 오프라인 지도 및 GPS 앱 입니다. 완전히 무료이며, 광고도, 추적기도 없습니다. 오픈소스 커뮤니티와 [**MapsWithMe**][mapswithme]/**Maps.Me** 앱의 개발자가 정성을 다해 제작하였습니다. [OpenStreetMap][openstreetmap] 데이터 기반으로 구동 됩니다. | ||
|
|
||
| **Organic Maps** 은 모든 기능이 100% 인터넷 연결 없이 지원하는 몇 안 되는 애플리케이션 중 하나입니다. Organic Maps을 설치하고 지도를 다운로드한 뒤 SIM 카드를 던저 버리도, 네트워크에 데이터 전송 없이 배터리 한 번 충전으로 일주일간 여행할 수 있습니다. |
There was a problem hiding this comment.
[P3] Complete a Korean proofreading pass
Concrete corrections include 던저 버리도 → 던져 버려도, payment 결재 → 결제 at line 90, and 벌레 → 농약 at line 62: the source's organic-food joke says “pesticides,” not “bugs.” Also fix repeated particle/spacing errors such as Organic Maps을 → Organic Maps를, Organic Maps은 → Organic Maps는, and 앱 입니다 → 앱입니다. Keep the platform spelling iOS at line 68 and attach Korean particles without an extra space.
| {name = "faq", feed = false}, | ||
| {name = "news", feed = true}, | ||
| ] | ||
| taxonomies = [{ name = "faq", feed = false }, { name = "news", feed = true }] |
There was a problem hiding this comment.
[P3] Remove unrelated configuration formatting churn
Parsing master:config.toml and this file produces identical configuration objects after removing the new Korean language table. All changes outside [languages.ko] are formatting-only, including every other language's taxonomy array and the FAQ language lists. Revert that unrelated reformatting so the PR's configuration diff is limited to adding Korean.
| @@ -0,0 +1,68 @@ | |||
| --- | |||
There was a problem hiding this comment.
[P3] Use LF line endings for the new donation file
This file uses CRLF throughout, unlike its English source. git diff --check master...HEAD reports 68 trailing-whitespace errors, all in this file. Normalize it to LF when completing the translation so the new file passes the whitespace check.
|
@channel101 thanks! Would you please rebase and check comments? There are new pages to translate too. Or if you are okay, I can try to translate everything, and you will proof-read? What do you prefer? |
@biodranik Thank you for the suggestion! That sounds great. Just let me know when it's ready for me to proofread. Thank you! |
54cf51a : added partial korean translations on homepage (Needs More Translations)
Screenshots On 54cf51a