Repository navigation
fix(sdk): require 12-byte AES-GCM IVs (DSPX-4496) - #1060
Merged
Merged
Conversation
The reader takes each segment's IV from a fixed 12-byte prefix, so an IV of any other length writes a TDF that cannot be read back. Reject it in AesGcmCipher.encrypt with a ConfigurationError, matching java-sdk#393. Also drop the unused `iv` parameter from AesGcmCipher.decrypt, which always reads the IV from the buffer, and fix its doc comment. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 6, 2026
|
dmihalcik-virtru
marked this pull request as ready for review
October 6, 2026 20:10
pflynn-virtru
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AesGcmCipher.encryptrejects an IV that isn't exactly 12 bytes, throwing aConfigurationError. This matches java-sdk#393.AesGcmCipher.decryptdrops its unusedivparameter, since it always reads the IV from the buffer's own prefix. Its doc comment, which wrongly said "CBC mode", is fixed too.Why
The reader takes each segment's IV from a fixed 12-byte prefix. An IV of any other length writes a TDF that encrypts without error but can never be read back.
How to test
cd lib && npm test. See the newtests/mocha/unit/aes-gcm-cipher-iv.spec.ts.Risk
Low. The SDK always passes 12-byte IVs. Only an external caller that passes a malformed IV to
AesGcmCipher.encryptwill now get an error, and its output was unreadable anyway.DSPX-4496 series
mainmainmainmainAesGcmEncryptorSPIDSPX-4496-encrypted-segment-sizeDSPX-4496-aes-gcm-encryptor#1059, #1060 and #1062 stand alone. #1061 ← #1063 ← #1018 is a stack.