Repository navigation
Conversation
Normalize version chronology, quarantine invalid selector identities, load both snapshots atomically, and cache only immutable successful historical content. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Expose comparison actions, preserve the desktop Viewer fallback, reject mobile one-pane fallback, and mount the Text comparison only after both snapshots load. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This was referenced Aug 14, 2026
hweihwang
requested review from
max-nextcloud and
mejo-
and removed request for
max-nextcloud
August 14, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one sentence: Collectives now opens the Text semantic comparison when comparing page versions, with the old Viewer path kept as fallback.
What and why
Comparing two versions of a page today opens both documents in Viewer, side by side, with no highlighting. That is two documents in one window, not a comparison. This PR wires Collectives to the semantic comparison Text now provides — and keeps the old path working where it must.
What's in this PR
The whole argument for this PR: the same pair, before and after. The fallback still works — it's just no longer the comparison experience.
On mobile the dialog refuses rather than degrade. The dialog keeps full height, so most of the image is empty — that's real modal behaviour.
Design notes
b7042764made theisTextEditwatcher async and added member loading inside it; combined with this branch's lazy editor creation, a member request still in flight could create an editor after edit mode ended — and a hidden editor can write back stale content over a version restore.ensureEditor()now reuses one in-flight setup promise, runs setup in parallel with member loading, and destroys the editor if edit mode ended during setup. A browser test holds both async paths, leaves edit mode, then restores a version and confirms the restored content survives.Stack
Requires the Text stack: nextcloud/text#9043 → #9044 → #9045 → #9046 (all four merge and release first). Followed by #2698. Review focus:
src/components/Page/TextEditor.vue,src/composables/useEditor.ts.Verification
lint(tsc + eslint) passes; unit suite 26/26. Recorded live end-to-end runs at this tip: NC35 28/28 and NC34 28/28 (stock Viewer8b68b1bd). A fresh pass with current Viewermaster(33dc36ba) is due before this leaves draft — the stack uses the stockcompare()API, so no Viewer change is involved.AI assistance
Commits carry
Assisted-by: Codex:gpt-5.6-sol; an independent review pass was run with Claude Opus 5, who flagged the stale stock-Viewer commit in the earlier E2E record. Description drafted with Hermes (deepseek-v4-pro) from my notes, then reviewed by me.Related
No closing keyword — the stack completes this issue at the final unit.