Repository navigation
Conversation
Normalize version chronology, quarantine invalid selector identities, load both snapshots atomically, and cache only immutable successful historical content. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Expose comparison actions, preserve the desktop Viewer fallback, reject mobile one-pane fallback, and mount the Text comparison only after both snapshots load. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Namespace current and historical canonical identities, retain rollover aliases, quarantine genuine duplicates, and preserve unrelated route state. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Restore comparison pairs from URLs, keep history and slug updates scoped, report invalid or unavailable identities, and copy only successful pinned links. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This was referenced Aug 14, 2026
hweihwang
requested review from
max-nextcloud and
mejo-
and removed request for
max-nextcloud
August 14, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one sentence: shareable URLs that pin two exact revisions and never silently change.
What and why
A comparison you can't link to can't be discussed — and a link that silently follows later edits shows a different comparison under the same URL. This PR pins comparisons to exact revision identities.
What's in this PR
compareFrom/compareToURL parameters pin two exact revisions; the pair survives reload, Back, Forward, copy into another session, and page renamecurrent:<id>/version:<id>) — aliases keep previously shared links resolvingThe pinned identity is never silently replaced. The dialog keeps full height; Retry sits bottom right.
Design notes
Stack
Depends on: #2697. Final unit of six. Opened stacked on C1 — the diff narrows once #2697 merges; I'll rebase before review.
Verification
lint(tsc + eslint) passes; unit suite 46/46 covering identity resolution, aliases, quarantine and every rejected input class. The route matrix (copy, reload, Back, Forward, rename, malformed parameters) is covered by the live suite in the recorded runs (NC35 28/28, NC34 28/28). Fresh live pass with Viewer33dc36badue before leaving draft.AI assistance
Commits carry
Assisted-by: Codex:gpt-5.6-sol; an independent review pass was run with Claude Opus 5. Description drafted with Hermes (deepseek-v4-pro) from my notes, then reviewed by me.Related