Skip to content

Add shareable comparison links - #2700

Merged
hweihwang merged 1 commit into
review/collectives-version-comparisonfrom
review/collectives-version-comparison-routing
Sep 3, 2026
Merged

hweihwang merged 1 commit into
review/collectives-version-comparisonfrom
review/collectives-version-comparison-routing

Conversation

@hweihwang

@hweihwang hweihwang commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Part 6 of the version-comparison work for #599: shareable comparison links that pin two exact revisions.

  • compareFrom / compareTo pin two revisions; the pair survives reload, Back, Forward, copy and page rename
  • Namespaced identities (current: / version:) with aliases for older links; validation rejects non-strings, path separators, control characters, over-long values, identical and half-pairs
  • A missing version stays in the selector with a Retry action, never silently replaced; one history entry per path; rename canonicalizes only the slug
  • The e2e workflows now run against the signed Text comparison commit b5ff1b0ce8, pinned as the checkout ref in cypress-e2e.yml and playwright.yml; the semantic suite runs in Chromium

Depends on: #2699 (base review/collectives-version-comparison). Final unit of the six.

Full story, screenshots and the test matrix live in the #599 implementation update: #599 (comment)

AI disclosure: developed with OpenAI Codex (gpt-5.6-sol). Codex generated the implementation and tests under my direction; I reviewed, cleaned and verified the code, ran the full test and CI matrix, and signed the commits personally.

@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch 2 times, most recently from a964840 to 2c826e0 Compare August 17, 2026 15:27
@benjaminfrueh
benjaminfrueh self-requested a review August 18, 2026 07:55
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch from 2c826e0 to 80fb7fe Compare September 1, 2026 21:10
@hweihwang
hweihwang marked this pull request as ready for review September 1, 2026 21:24
@hweihwang
hweihwang requested review from benjaminfrueh and removed request for max-nextcloud, mejo- and silverkszlo September 1, 2026 21:34
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch 2 times, most recently from 10d62ec to 8b07a6a Compare September 2, 2026 08:54
Assisted-by: OpenAI Codex:gpt-5.6-sol
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
hweihwang force-pushed the review/collectives-version-comparison-routing branch from 8b07a6a to be44588 Compare September 3, 2026 08:40
@hweihwang
hweihwang merged commit 63306dd into main Sep 3, 2026
76 of 82 checks passed
@hweihwang
hweihwang deleted the review/collectives-version-comparison-routing branch September 3, 2026 12:17
@mejo- mejo- mentioned this pull request Oct 19, 2026
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants