Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
…n details dialog" This reverts commit 7ea636b.
Janpot
added
scope: icons
github-actions
Bot
added
the
PR: out-of-date
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The icon search only knows an icon's name and the tags from Google's Material Symbols metadata. Searches for everyday names ("cog", "kebab menu", "dustbin") or for what an icon looks like ("eye with slash", "check in circle", "funnel") often return nothing or rank the right icon far down.
This adds
iconDescriptions.jsonwith, for every icon, extra search keywords and a one-sentence visual description.pnpm docs:mdicons:synonymsnow merges those words intosynonyms.jsthe same way it merges Google's tags, so the search page itself does not change.Notes for reviewers:
icon-descriptionsskill (.agents/skills/icon-descriptions), withdocs/scripts/iconDescriptions.mjsrendering the icon sheets and validating and merging the output. Running the skill again only processes icons that are missing from the JSON, so it can be rerun when icons are added.docs:mdicons:synonymswas broken on master: it importedLEGACY_OUTLINE_ICONSfrombuilder.test.mjs, which now imports Vitest and fails under babel-node. The list moved topackages/mui-icons-material/legacyOutlineIcons.mjs.