Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots of text sometimes render with slightly different anti-aliasing between CI runs. The regression browser runs headful with CPU raster, and Skia picks SIMD code paths based on the host CPU, so a run on a different CircleCI host can change a few glyph edges. Master build 52568 (#44450, a docs-only change) auto-approved 5 such diffs, and every PR based on it then showed them as changed (for example #49204 and #49207).
This PR adds Chromium flags that keep rasterization independent of the host:
--disable-skia-runtime-opts(the same flag Chromium's web tests use for this), plus--disable-lcd-text,--disable-font-subpixel-positioning,--force-color-profile=srgband--disable-gpu.Expect a one-time Argos diff across many screenshots that needs approval.