Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
# Conflicts: # .agents/skills/icon-descriptions/SKILL.md # docs/data/material/components/material-icons/SearchIcons.js
…n details dialog" This reverts commit 7ea636b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype for ranking icon search results by meaning instead of by keyword match order. Builds on #49204, which adds generated keywords and visual descriptions for every icon to
synonyms.js.Keyword search finds icons but orders them poorly: "bell" puts ConveyorBelt first, "car" puts Card icons next to cars, and searches with no keyword hit ("rubbish", "puppy") return nothing. This uses the potion-base-8M static embedding model to score how close each icon is to the query and orders the results by that.
How it works:
docs/scripts/buildIconSearchIndex.mjsprecomputes a vector for every single-token word in the model's vocabulary and one vector per icon (its name and synonyms), and writes them todocs/public/static/material-icons/.Notes for reviewers:
synonyms.js, since the synonyms script sorts words and drops words contained in longer ones.pnpm docs:mdicons:search-indexwhensynonyms.jschanges. Theicon-descriptionsskill does that as part of its workflow.