Repository navigation
docs(contracts): move the registry-named contract folders to docs/contracts - #11056
Conversation
…acts Move 38 plugin-author contract folders from docs/conventions to docs/contracts unchanged, and repoint their em-dash allowlist entries. Readers already try docs/contracts first. The folders a registry names by README path, and the two lane-source folders, move in the next parts of the stack so this change's review diff collapses every move. The TEMPORARY (#7537) .lycheeignore entries skip local links into the moved folders until the old-path stubs land, and relative links inside the moved folders until the later moves and the reference rewrites land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
…tracts Move seven plugin-author contract folders that a registry names by README path (enforcement-ladder, hook-observability, hook-precision, pr-scope-budget, pre-pr-ordering, seam-phrasing, standards) from docs/conventions to docs/contracts unchanged, and repoint those registries: the conformance dimension owners, the shared-copies and cross-plugin source registries, and the em-dash allowlist entries. Resync the eleven shared copies, which name their canonical source, with a patch fragment for each of the nine carrying plugins, and point the standards schema $id at its new path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8
…gistered # Conflicts: # scripts/em-dash-purged-paths.txt
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found. critical-findings: 0 I read the whole diff (36 files). It is a docs-only relocation of seven contract folders from
Trust-control and trusted-path check:
The change does not spend anything and does not touch billing, so no hold applies. |
|
claude-review reviewed No findings. I read all 36 changed files in
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 561ab729b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | dim-23 | Every guardrails hook fix pins its over-fire as a stay-quiet test case | docs/conventions/hook-precision/README.md#Conformance | judgment: for each hook under `plugins/guardrails/hooks/`, does its co-located test carry a stay-quiet case for each over-fire fix? (applies to `guardrails`) | judgment | no | plugin | | ||
| | dim-24 | No plugin states a pre-PR step order that conflicts with the canonical one | docs/conventions/pre-pr-ordering/README.md#Conformance | judgment: does any surface in this plugin list pre-PR steps, and if so does it cite the sequence instead of re-listing it in another order? | judgment | no | plugin | | ||
| | dim-23 | Every guardrails hook fix pins its over-fire as a stay-quiet test case | docs/contracts/hook-precision/README.md#Conformance | judgment: for each hook under `plugins/guardrails/hooks/`, does its co-located test carry a stay-quiet case for each over-fire fix? (applies to `guardrails`) | judgment | no | plugin | | ||
| | dim-24 | No plugin states a pre-PR step order that conflicts with the canonical one | docs/contracts/pre-pr-ordering/README.md#Conformance | judgment: does any surface in this plugin list pre-PR steps, and if so does it cite the sequence instead of re-listing it in another order? | judgment | no | plugin | |
There was a problem hiding this comment.
This move leaves active consumers pointed at paths it deletes: docs/plugin-philosophy.md still links all seven moved contracts under docs/conventions/, and the /source-control:pull-request ready flow still instructs users to read docs/conventions/pre-pr-ordering/README.md. Those references no longer resolve at this commit, so the flow loses its canonical ordering source. Update the remaining links and repository path guidance, or retain compatibility stubs. The root guidance still places marketplace plugin contracts under docs/conventions/.
AGENTS.md reference: AGENTS.md:L109-L110
Useful? React with 👍 / 👎.
Refs: #7537
Summary
Part B1, layer 2 of 5, of the #7537 split, stacked on
docs/7537-b1-moves. It moves the seven contract folders that a registry names by README path: enforcement-ladder, hook-observability, hook-precision, pr-scope-budget, pre-pr-ordering, seam-phrasing and standards. It repoints those registries in the same change, so their checks stay green.Merge order. #10952 is re-split into five stacked layers so each review diff stays under
pr-review-main's 300 KB cap (MAX_DIFF_BYTES, measured with #10969'swrite-diff.py):docs/7537-b1-moves: 38 folders' pure moves (collapsed to rename lines) and the TEMPORARY link-check entries.docs/7537-b1-moves-registered: the 7 folders a registry names by README path, with those registries and the synced copies.docs/7537-b1-moves-lane: rendered-views and the two lane-source folders, plus every lane-source reference edit.docs/7537-b1-refs: the remaining reference rewrites.docs/7537-b2-stubs-v2: docs(contracts): leave stubs at the moved contracts' old paths #10957's stubs.Merge in that order: M, M2, M3, R, then B2. Each layer targets the branch below it. main squash-merges, so after a layer lands, retarget the next layer to main and merge main into it; until then its diff still carries the landed layer and is over the cap.
Fix
git mvof the seven folders (12 files), unchanged apart from the standards schema's$id, which now names its new path.check-standards-contract-bump.shrequires a version bump for a schema edit made after the move, but not for one made with it.scripts/shared-copies.txt,scripts/cross-plugin-source-registry.txt, and these folders' em-dash allowlist entries.Per-folder call (carried from #10952):
standards/moves because discipline, improvement, planning and review read it; it is a plugin contract under the owner's rule (#7537 (comment)).Verification
write-diff.pybuilds it: 235,896 bytes (under the cap, so printed whole), no line over 1,800 bytes. No lane source, sopr-review-maindoes not run on this layer.sync-shared-copies.sh --check,check-standards-contract-bump.sh, conformance, em-dash, cross-plugin drift and changelog checks pass against layer 1. The selected shell suites passed or were skipped, and the node suites pass (resolve-config's ownnode_modulesinstalled). The Python suites pass apart fromtest_reader_findings.py::…non_literal_stays_partial, which fails the same way on the main checkout atd5d8ff15.Related
Draft: a stacked layer of the #7537 B1 re-split; it goes through
/source-control:pull-request readyin merge order, after the layer below lands and main is merged in.🤖 Generated with Claude Code
https://claude.ai/code/session_01VQb9Q3ucKDVyHvpcU5cfU8