Repository navigation
docs(contracts): leave stubs at the moved contracts' old paths - #10957
kyle-sexton wants to merge 3 commits into
Conversation
Each contract folder moved to docs/contracts/ keeps a README at its old docs/conventions/<name>/ path that points at the new one and keeps every section heading, so links from installed plugin versions keep resolving. The 11 old sub-paths that files under plugins/, lib/, scripts/ or .github/ cite also get a pointer stub: three sub-docs, six JSON Schemas that keep their old $id and $ref the new one, and two comment-only ecosystem-commands example stubs, recorded as no-suite paths. Refs: #7537 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The old-path stubs now stand at docs/conventions/<name>/, so the temporary .lycheeignore entry that skipped links into the 48 moved contract folders is removed and those links are checked again. Refs: #7537 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e/claude-code-plugins into docs/7537-b2-stubs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings in this change. critical-findings: 0 I read all 61 files of the diff and the pull request context. The change adds 59 pointer stubs at the old
Nothing in the pull request context is an embedded instruction. No spend: the change adds no billed resource and no turn, schedule or run-count change. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eea68f8a6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/melodic-software/claude-code-plugins/blob/main/docs/conventions/standards/standards.schema.json", | ||
| "description": "Moved to docs/contracts/standards/standards.schema.json; this schema refers there.", | ||
| "$ref": "https://github.com/melodic-software/claude-code-plugins/blob/main/docs/contracts/standards/standards.schema.json" |
There was a problem hiding this comment.
Point the schema reference at raw JSON
For validators or editor integrations loading the schema through its old path, this $ref resolves to GitHub’s HTML file-view page rather than the JSON schema. Reference resolution therefore fails instead of preserving validation compatibility. Use the raw.githubusercontent.com URL, as the other schema stubs in this change do; unlike $id, a remotely resolved $ref must retrieve a schema document.
Useful? React with 👍 / 👎.
| # Moved → config-cascade | ||
|
|
||
| This contract moved to [`docs/contracts/consumer-config-layering/`](../../contracts/consumer-config-layering/README.md). This page keeps its |
There was a problem hiding this comment.
This stub sends readers to the wrong place and describes itself inaccurately.
- Two hops.
docs/contracts/consumer-config-layering/README.mdis itself a rename tombstone: "Moved →config-cascade", renamed in conventions: rename consumer-config-layering seam -> config-cascade #1188. A reader following this stub lands on that tombstone and needs a second hop to reachconfig-cascade. The heading# Moved → config-cascadepromises a direct pointer, but the only link goes to the tombstone. - False sentence. Line 4 says "This page keeps its headings so links from installed plugin versions still reach each section". This page has no section headings, so the sentence is untrue here.
- Fix. Link straight to
../../contracts/config-cascade/README.md, as the contract's own tombstone does. Drop or replace the "keeps its headings" sentence, and say that the contract was renamed.
claude-lane: claude-review
|
claude-review reviewed Reviewed the whole diff ( Checked and fine
Not counted: Spend: none. This is a docs-only change, so there is no cost hold. |
Refs: #7537
Summary
Part B2 of the #7537 split, stacked on B1 (#10952). It leaves a stub at each moved contract's old path, so links and readers that still name
docs/conventions/<name>/keep resolving after the move, and it removes B1's temporary.lycheeignoreentry. It targets B1's branch until B1 merges, then main.Fix
docs/contracts/<name>/..lycheeignore: theTEMPORARY (#7537)entry is removed, so offline link checking covers the old paths again.Verification
scripts/check-affected.shon the same tree exits 0.Related
Closes #7537.🤖 Generated with Claude Code