Skip to content

Restore browser verification after the homepage design review - #94

Closed
openbotgit[bot] wants to merge 1 commit into
masterfrom
bugfix/design-browser-verification
Closed

openbotgit[bot] wants to merge 1 commit into
masterfrom
bugfix/design-browser-verification

Conversation

@openbotgit

@openbotgit openbotgit Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

The browser suite still expected the tabs, About label and feeding gestures removed by #92. Update those checks for the four project cards, More navigation, selectable copy, single click feeding and descriptive share card alt. Preserve the viewport matrix, food reservations, both pond modes, mobile touch rejection, reduced motion and security coverage. No tests are skipped.

Also fix an actual #92 regression: the embedded Instrument Serif font violated font-src 'self'. Bundle the identical font bytes as a local asset and verify the font loads. The security policy and design remain unchanged. No #93 feeding access changes are included.

Base: d3bb71254ae1e6de4c0a0c248827cbee5812b284.
Verified head: 313659fad05add7ef4e2450017da0f4e9d0e08ae.

Failure map and local evidence covers every failure from the original Actions run, the reproduced CSP error and the font hash comparison.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing

  • npm run lint passes
  • npm run build succeeds through npm run test:e2e
  • Tested at mobile viewport sizes with Chromium emulation
  • npm run test:e2e: all 49 tests pass in 214.724 seconds, no skips. Original failing coverage passes in this production export rerun.
  • npm run test:pond: 54 tests pass.
  • npm audit --audit-level=high and git diff --check pass. Seven existing moderate audit findings remain; dependencies are unchanged.
  • Local environment: macOS, Node 26.5.0, Python 3.14.7, Playwright 1.61.0, Chromium 1228. Physical mobile devices remain untested.
  • Linux Actions with Node 22 also passes on this exact PR head: verification run 42993606909, including all 49 production browser tests in 252.613 seconds.
  • No merge, deployment or production workflow dispatch.

Screenshots (if applicable)

Local generated evidence: test-results/project-grid-{320,390,1440}.png and test-results/portfolio-final-{desktop,mobile}.png. Reviewed font readability and horizontal containment. Full page screenshots contain fixed element and offscreen animation artifacts; viewport assertions are the layout evidence.

@luinbytes
luinbytes marked this pull request as ready for review November 12, 2026 00:35
@openbotgit openbotgit Bot mentioned this pull request Nov 12, 2026
9 of 11 tasks
@openbotgit

openbotgit Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by merged #93, now on master at 5838bcd.

This PR's 313659f was cherry-picked into #93 as 155a448; their stable patch IDs match. The squash merge includes those fixes:

  • app/fonts/instrument-serif-latin-400.woff2, app/globals.css and docs/verification/design-92-browser-drift.md are identical to this PR's head.
  • tests/browser/browser_test.py retains the baseline updates and adds the instant heading scroll that fixed a Linux test race.
  • tests/browser/issues_test.py retains More navigation and now verifies Lu's requested pointer feeding with no Feed control, replacing the older keyboard button expectation.

No unique needed fix remains here. Current master's verification, build and deployment all passed. Leaving this PR open for Lu; no duplicate implementation is needed.

Copy link
Copy Markdown
Owner

Closing this one. All of its fixes landed through #93, and QA has verified the live site (no feed button, open-water clicks feed in both modes, navigation clicks do not feed). Nothing here needs merging.

@luinbytes luinbytes closed this Nov 12, 2026
@openbotgit openbotgit Bot mentioned this pull request Nov 12, 2026
6 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant