Repository navigation
Clear ESLint toolchain audit findings - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clear the seven moderate development dependency findings in the ESLint toolchain. Update
typescript-eslintto stable8.72.2and scope aminimatch@11.0.1override to@typescript-eslint/typescript-estree, then regenerate the npm lockfile.The audit's suggested
typescript-eslint@8.36.0downgrade still reports all seven findings when tested. Latest stable8.72.2still requests vulnerable minimatch 10.x, so the narrow override selects the first version outside the advisory range. Remove the override when upstream adopts a patched compatible dependency.The dependency update changes only
package.jsonandpackage-lock.json. No lint rule or runtime dependency changes were needed. Production audit remains zero. No changes to #94.The first CI run hit the existing heading-click race. Following the requested follow-up, a separate two-line browser test change waits for the project grid entrance transform to finish and recenters the heading before the real click. Frame sampling confirmed that an instant scroll alone still left 22px of grid motion. The click and pointer-isolation assertion remain, with no forced click or disabled animation. Product code is unchanged.
Type of Change
Testing
Head:
ca301b4d9ac000fda7429145a65c167ccc5cf188.npm run lintand production build pass.npm lsconfirms the overridden minimatch version with a valid dependency tree.git diff --checkpasses; every changed non-root lock entry is development only.No merge or deployment. Full local browser tests were not repeated; the exact final head will be verified in Linux CI.
Screenshots (if applicable)
No UI changes.