Repository navigation
Remove the Feed fish button - #93
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59dfb2f. Configure here.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59dfb2fb67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…e button" This reverts commit 5eb53e3.
Description
Remove the Feed fish button entirely, including its focus-only replacement. Clicking or tapping unobscured pond water feeds the fish in both ASCII and Pixel modes. Feeding is pointer only, as requested.
Remove the button-only status state, styles and
pond-feedcustom event wiring. Assistive text describes clicking or tapping open water and does not promise a keyboard feeding control. The pond view selector remains.Repair inherited CI failures using the reviewed baseline fixes from #94: align browser coverage with the project grid, More navigation, selectable copy and single-click feeding; serve the identical Instrument Serif font bytes from the same origin to satisfy the existing CSP. No tests are skipped and CSP is unchanged. #94 itself is unchanged.
Type of Change
Testing
Verified head:
cb0744df647c610ac353cbfbcd44021c7eff92eb.git diff --checkpasses.The first Linux rerun exposed a test scroll race: centering an oversized project card could put its heading beneath the fixed header. The test now centers the heading with an instant scroll before making a real click. No forced click, skipped assertion or interaction implementation change was used for that correction.
Physical mobile devices and screen readers remain untested. No merge or production deployment.
Screenshots
Generated local behavior evidence remains in the isolated checkout's
test-results/. The authoritative feeding evidence is the production browser test's food counters, input coordinates and DOM assertions.