Skip to content

chore: carry the template's prose-token documents verbatim and the julia test (replaces #24) - #28

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/mint-verbatim-documents-v2
Nov 14, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/mint-verbatim-documents-v2

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Replaces #24.

Self-reviewed against what Codex raised on #24:

  • The aspect-test banner prints the project token literally (Codex, P2): the cause is the template's own tests/aspect_tests.sh line 42, which is listed verbatim. This PR must keep it byte-identical, so it is fixed at source in rsr-template-repo#390. This repository picks it up at the next template sync (its copy will then differ from d183b32 on purpose).

Checked locally: all 21 manifest entries exist; check-mint-tokens.sh and check-hypatia-rule-order.sh behave as on #24's head. Only README.adoc still has unfilled tokens, which the stacked PR fills. The DEED line 228 and root-shape reds on main are unchanged. Not proven here: a CI run.


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7a85748 and 8b05920.

Files selected for processing: 5

  • .machine_readable/mint-verbatim.txt
  • CHANGELOG.adoc
  • docs/status/TEST-NEEDS.adoc
  • tests/aspect_tests.sh
  • tests/workflows/julia_library_test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:24:23.995241Z 8b05920 New commits
🔒 Security Review ✅ Completed 2026-11-14T17:23:45.800840Z 8b05920 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0264e9a35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# Verify the real substitution expression reaches Project.toml, including
# every occurrence of the token in the new explanatory comment.
mapfile -d '' -t sed_args < "$fixture/sed.args"
sed "${sed_args[@]}" "$repo/archetypes/julia-library/overlay/Project.toml.in" > "$fixture/Project.toml"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Skip template-only checks when the archetype is absent

In this minted repository, build/just/repo-init.just deliberately removes the entire archetypes/ directory, so the newly advertised bash tests/workflows/julia_library_test.sh command always exits here with sed: can't read .../archetypes/julia-library/overlay/Project.toml.in; the later workflow check has the same missing-fixture dependency. Either avoid carrying this template-only test into minted trees or make it skip the overlay-specific assertions when archetypes/julia-library is absent.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, and it is real: bactrian main has no archetypes/ directory (the mint removes it), while tests/workflows/julia_library_test.sh reads archetypes/julia-library/overlay/... at line 112 and line 176, so the test cannot pass in a minted tree. Two facts bound it: the file is carried byte-identical because mint-verbatim.txt lists it, and nothing in this repository's CI invokes it (only the template's own tests/e2e/julia_mint_test.sh does), so no check here goes red from it. The fix belongs at the source, not in this repository: the template either stops carrying template-only tests into children or lets them say so explicitly. That is a design choice for the owner, raised with the sweep; no local edit, since a divergent copy would break the byte-identity this PR exists to keep. Not claimed fixed.


Generated by Claude Code

Syncs .machine_readable/mint-verbatim.txt from the template (the list now has the
six prose-token documents) and brings the documents on it that differ here back
to the template's bytes: CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc,
tests/aspect_tests.sh. The damage report, survey-template-damage.sh and
check-mint-tokens.sh already equal the template on main. The mint had rewritten
the template name or the project-name brace token inside their prose; the
mint-token and placeholder gates skip files on the list.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
mint-verbatim.txt lists it (synced from the template at d183b32) and
repo-init.just exits on a listed file that is absent. Carry the template's
file byte-identical. All 21 manifest entries now exist.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
@hyperpolymath
hyperpolymath force-pushed the fix/mint-verbatim-documents-v2 branch from d0264e9 to 8b05920 Compare November 14, 2026 17:20
@hyperpolymath
hyperpolymath merged commit 5c5cc38 into main Nov 14, 2026
22 of 25 checks passed
@hyperpolymath
hyperpolymath deleted the fix/mint-verbatim-documents-v2 branch November 14, 2026 17:20
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants