Repository navigation
chore: carry the template's prose-token documents verbatim and the julia test (replaces #24) - #28
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0264e9a35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Verify the real substitution expression reaches Project.toml, including | ||
| # every occurrence of the token in the new explanatory comment. | ||
| mapfile -d '' -t sed_args < "$fixture/sed.args" | ||
| sed "${sed_args[@]}" "$repo/archetypes/julia-library/overlay/Project.toml.in" > "$fixture/Project.toml" |
There was a problem hiding this comment.
Skip template-only checks when the archetype is absent
In this minted repository, build/just/repo-init.just deliberately removes the entire archetypes/ directory, so the newly advertised bash tests/workflows/julia_library_test.sh command always exits here with sed: can't read .../archetypes/julia-library/overlay/Project.toml.in; the later workflow check has the same missing-fixture dependency. Either avoid carrying this template-only test into minted trees or make it skip the overlay-specific assertions when archetypes/julia-library is absent.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified, and it is real: bactrian main has no archetypes/ directory (the mint removes it), while tests/workflows/julia_library_test.sh reads archetypes/julia-library/overlay/... at line 112 and line 176, so the test cannot pass in a minted tree. Two facts bound it: the file is carried byte-identical because mint-verbatim.txt lists it, and nothing in this repository's CI invokes it (only the template's own tests/e2e/julia_mint_test.sh does), so no check here goes red from it. The fix belongs at the source, not in this repository: the template either stops carrying template-only tests into children or lets them say so explicitly. That is a design choice for the owner, raised with the sweep; no local edit, since a divergent copy would break the byte-identity this PR exists to keep. Not claimed fixed.
Generated by Claude Code
Syncs .machine_readable/mint-verbatim.txt from the template (the list now has the six prose-token documents) and brings the documents on it that differ here back to the template's bytes: CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc, tests/aspect_tests.sh. The damage report, survey-template-damage.sh and check-mint-tokens.sh already equal the template on main. The mint had rewritten the template name or the project-name brace token inside their prose; the mint-token and placeholder gates skip files on the list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
mint-verbatim.txt lists it (synced from the template at d183b32) and repo-init.just exits on a listed file that is absent. Carry the template's file byte-identical. All 21 manifest entries now exist. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
d0264e9 to
8b05920
Compare
|



Replaces #24.
mint-verbatim.txtsynced from the template at d183b32, andCHANGELOG.adoc,docs/status/TEST-NEEDS.adoc,tests/aspect_tests.shbyte-identical to the template) plus one commit on top.tests/workflows/julia_library_test.sh, carried byte-identical from the template at d183b32. The synced list names it andrepo-init.justline 184 exits on a listed file that is absent (Codex, P1, my miss). Checked: all 21 manifest entries now exist.Self-reviewed against what Codex raised on #24:
tests/aspect_tests.shline 42, which is listed verbatim. This PR must keep it byte-identical, so it is fixed at source in rsr-template-repo#390. This repository picks it up at the next template sync (its copy will then differ from d183b32 on purpose).Checked locally: all 21 manifest entries exist;
check-mint-tokens.shandcheck-hypatia-rule-order.shbehave as on #24's head. OnlyREADME.adocstill has unfilled tokens, which the stacked PR fills. The DEED line 228 and root-shape reds on main are unchanged. Not proven here: a CI run.Generated by Claude Code