Repository navigation
chore: finish the template upgrade, without the verbatim documents (replaces #11, needs #24) - #26
hyperpolymath wants to merge 6 commits into
Conversation
Syncs .machine_readable/mint-verbatim.txt from the template (the list now has the six prose-token documents) and brings the documents on it that differ here back to the template's bytes: CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc, tests/aspect_tests.sh. The damage report, survey-template-damage.sh and check-mint-tokens.sh already equal the template on main. The mint had rewritten the template name or the project-name brace token inside their prose; the mint-token and placeholder gates skip files on the list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
… the rule order Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48f8d57c0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| docs/status/TEST-NEEDS.adoc # prose records the lowercase brace placeholders it converted | ||
| scripts/survey-template-damage.sh # searches children for an unfilled project-name brace token | ||
| scripts/check-mint-tokens.sh # the gate's own comments name the tokens it checks | ||
| tests/aspect_tests.sh # a comment names the lowercase brace token that symbol names may carry |
There was a problem hiding this comment.
Let the mint substitute the aspect-test heading
When just repo-init mints any child, this manifest entry excludes the entire script from mint_files, so the newly added live {{PROJECT}} token on line 42 remains literal in the child's test banner. check-no-placeholders.sh also imports this same manifest as its allowlist, meaning validation will silently accept the leak; protect the fixture comment without making the whole script verbatim.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified, the cause is upstream: the template's own tests/aspect_tests.sh line 42 carries the token and is listed verbatim. Fixed at source in rsr-template-repo#390 (the banner takes the repository name at run time, with a guard test). This PR is closed; its content moved to #29, stacked on #28, which keeps the file byte-identical to the template pin.
Generated by Claude Code
|
|
||
| The *K9 conformance* badge in the row at the top becomes live after | ||
| `just repo-init` replaces the `{{OWNER}}` and `{{REPO}}` placeholders in its URL | ||
| `just repo-init` replaces the `hyperpolymath` and `bactrian` placeholders in its URL |
There was a problem hiding this comment.
Keep the owner token renderable in the README
When a child is minted under an owner other than hyperpolymath, replacing {{OWNER}} here with the template's literal owner leaves that owner unchanged: the self-name pass rewrites bactrian globally, but SELF_OWNER_SED only operates on Justfile and sonar-project.properties. The resulting child README therefore says that repo-init replaced the hyperpolymath and <child-repo> placeholders even though its badge URL uses the child's actual owner; retain the owner token so the normal substitution pass renders this sentence correctly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified. The cause is upstream: the template's README sentence (line 145) carries the owner and repository tokens as prose, and the mint substitutes README.adoc, so every child reads "replaces the and placeholders". Fixed at source: rsr-template-repo#391 rewords it without tokens and adds a guard. This PR is closed; its content moved to #29, which carries the by-hand fill as a stopgap. Once #391 merges and syncs, the README line in bactrian takes the template wording. Left open until then.
Generated by Claude Code
| tests/workflows/mint_cleanup_test.sh # instruction-block fixture | ||
| tests/workflows/self_name_pass_test.sh # template-name fixtures | ||
| tests/workflows/template_conformance_test.sh # template-slug fixtures | ||
| tests/workflows/julia_library_test.sh # PACKAGE_UUID brace-token fixture |
There was a problem hiding this comment.
Remove the nonexistent verbatim manifest entry
For any non-chain template mint that reaches the manifest preflight, this entry makes just repo-init abort before prompting or writing because tests/workflows/julia_library_test.sh does not exist in this commit (the available Julia tests are under tests/e2e/). The recipe explicitly checks every MINT_VERBATIM path with [ -f "$_v" ] and exits on a stale entry, so this blocks the template's primary mint path rather than merely excluding the wrong file.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified and fixed in the replacement: tests/workflows/julia_library_test.sh is now carried byte-identical in #28 (the replacement for #24), and #29 is stacked on it. All 21 manifest entries exist there. This PR is closed.
Generated by Claude Code
|
Closing in favour of #29, the same content restacked on #28 (the #24 replacement). The only difference is tests/workflows/julia_library_test.sh, which comes from #28. The branch stays for the owner to delete. Generated by Claude Code |
…eplaces #26, needs the #24 replacement) (#29) * chore: carry the template's prose-token documents verbatim Syncs .machine_readable/mint-verbatim.txt from the template (the list now has the six prose-token documents) and brings the documents on it that differ here back to the template's bytes: CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc, tests/aspect_tests.sh. The damage report, survey-template-damage.sh and check-mint-tokens.sh already equal the template on main. The mint had rewritten the template name or the project-name brace token inside their prose; the mint-token and placeholder gates skip files on the list. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ * chore: carry tests/workflows/julia_library_test.sh verbatim mint-verbatim.txt lists it (synced from the template at d183b32) and repo-init.just exits on a listed file that is absent. Carry the template's file byte-identical. All 21 manifest entries now exist. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ * chore: drop the retired .cursorrules and .windsurfrules Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit a7de0af) * chore: remove the stale build/docs-seed hypatia exemption and refresh the rule order Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit ba3baa5) * docs: fill the README repo-init sentence with this repository's identity Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit 523eeba) * fix(abi): fill the foreign-library tokens in Foreign.idr and Types.idr Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit 7f7e602) * docs: regenerate the repository map Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ --------- Co-authored-by: Claude <noreply@anthropic.com>



Replaces #11. Depends on #24 and must merge after it.
This branch is stacked on #24 (
fix/mint-verbatim-documents, head 008eea6). Its first four files in the diff (.machine_readable/mint-verbatim.txt,CHANGELOG.adoc,docs/status/TEST-NEEDS.adoc,tests/aspect_tests.sh) are #24's own and disappear from the diff once #24 merges. This PR adds five commits on top.Why a replacement: #11 rewrote the template's prose-token documents, which the mint-verbatim list says must stay byte-identical to the template. #24 restores them. This PR keeps every other content change of #11 and leaves those documents alone.
Kept from #11 (one commit each):
.cursorrulesand.windsurfrulesbuild/docs-seed/exemption in.hypatia-ignore(the path does not exist) and refreshhypatia-rule-order.json{{OWNER}},{{REPO}}){{project}}tokens insrc/interface/Abi/Foreign.idrandTypes.idrdocs/architecture/REPOSITORY-MAP.adocwithscripts/gen-repo-map.shDropped from #11 (now #24's job, byte-equal to the template):
CHANGELOG.adoc,tests/aspect_tests.sh,docs/reports/compliance/RSR-TEMPLATE-DAMAGE-2026-10-30.adoc,scripts/survey-template-damage.sh,scripts/check-mint-tokens.sh, and the longermint-verbatim.txtentry.Checked locally on this head:
check-no-placeholders.sh,check-mint-tokens.sh,check-hypatia-ignore.shandcheck-hypatia-rule-order.shexit 0. Not clean, same as on #24's head and not caused here:check-internal-links.sh(3 dead links, the links slice) andcheck-container-pins.sh(floating wolfi-base, the digest-pin slice). The map regeneration also picked up entries that main's map lacked (.claude/,.gitbot-fleet/,CODE_OF_CONDUCT.adoc), because the generator reads the tree.Not proven here: a full CI run. The DEED line 228 and root-shape reds on main are unchanged by this PR.
Generated by Claude Code