Skip to content

chore: finish the template upgrade, without the verbatim documents (replaces #11, needs #24) - #26

Closed
hyperpolymath wants to merge 6 commits into
mainfrom
fix/finish-template-upgrade-without-verbatim
Closed

hyperpolymath wants to merge 6 commits into
mainfrom
fix/finish-template-upgrade-without-verbatim

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Replaces #11. Depends on #24 and must merge after it.

This branch is stacked on #24 (fix/mint-verbatim-documents, head 008eea6). Its first four files in the diff (.machine_readable/mint-verbatim.txt, CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc, tests/aspect_tests.sh) are #24's own and disappear from the diff once #24 merges. This PR adds five commits on top.

Why a replacement: #11 rewrote the template's prose-token documents, which the mint-verbatim list says must stay byte-identical to the template. #24 restores them. This PR keeps every other content change of #11 and leaves those documents alone.

Kept from #11 (one commit each):

  • drop the retired .cursorrules and .windsurfrules
  • remove the stale build/docs-seed/ exemption in .hypatia-ignore (the path does not exist) and refresh hypatia-rule-order.json
  • fill the README repo-init sentence ({{OWNER}}, {{REPO}})
  • fill the {{project}} tokens in src/interface/Abi/Foreign.idr and Types.idr
  • regenerate docs/architecture/REPOSITORY-MAP.adoc with scripts/gen-repo-map.sh

Dropped from #11 (now #24's job, byte-equal to the template): CHANGELOG.adoc, tests/aspect_tests.sh, docs/reports/compliance/RSR-TEMPLATE-DAMAGE-2026-10-30.adoc, scripts/survey-template-damage.sh, scripts/check-mint-tokens.sh, and the longer mint-verbatim.txt entry.

Checked locally on this head: check-no-placeholders.sh, check-mint-tokens.sh, check-hypatia-ignore.sh and check-hypatia-rule-order.sh exit 0. Not clean, same as on #24's head and not caused here: check-internal-links.sh (3 dead links, the links slice) and check-container-pins.sh (floating wolfi-base, the digest-pin slice). The map regeneration also picked up entries that main's map lacked (.claude/, .gitbot-fleet/, CODE_OF_CONDUCT.adoc), because the generator reads the tree.

Not proven here: a full CI run. The DEED line 228 and root-shape reds on main are unchanged by this PR.


Generated by Claude Code

Syncs .machine_readable/mint-verbatim.txt from the template (the list now has the
six prose-token documents) and brings the documents on it that differ here back
to the template's bytes: CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc,
tests/aspect_tests.sh. The damage report, survey-template-damage.sh and
check-mint-tokens.sh already equal the template on main. The mint had rewritten
the template name or the project-name brace token inside their prose; the
mint-token and placeholder gates skip files on the list.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
… the rule order

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d5e5111 and 48f8d57.

Files selected for processing: 12

  • .cursorrules
  • .hypatia-ignore
  • .machine_readable/mint-verbatim.txt
  • .machine_readable/policies/hypatia-rule-order.json
  • .windsurfrules
  • CHANGELOG.adoc
  • README.adoc
  • docs/architecture/REPOSITORY-MAP.adoc
  • docs/status/TEST-NEEDS.adoc
  • src/interface/Abi/Foreign.idr
  • src/interface/Abi/Types.idr
  • tests/aspect_tests.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 16:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T16:53:14.764236Z 48f8d57 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-14T16:53:46.884677Z 48f8d57 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48f8d57c0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

docs/status/TEST-NEEDS.adoc # prose records the lowercase brace placeholders it converted
scripts/survey-template-damage.sh # searches children for an unfilled project-name brace token
scripts/check-mint-tokens.sh # the gate's own comments name the tokens it checks
tests/aspect_tests.sh # a comment names the lowercase brace token that symbol names may carry

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Let the mint substitute the aspect-test heading

When just repo-init mints any child, this manifest entry excludes the entire script from mint_files, so the newly added live {{PROJECT}} token on line 42 remains literal in the child's test banner. check-no-placeholders.sh also imports this same manifest as its allowlist, meaning validation will silently accept the leak; protect the fixture comment without making the whole script verbatim.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, the cause is upstream: the template's own tests/aspect_tests.sh line 42 carries the token and is listed verbatim. Fixed at source in rsr-template-repo#390 (the banner takes the repository name at run time, with a guard test). This PR is closed; its content moved to #29, stacked on #28, which keeps the file byte-identical to the template pin.


Generated by Claude Code

Comment thread README.adoc

The *K9 conformance* badge in the row at the top becomes live after
`just repo-init` replaces the `{{OWNER}}` and `{{REPO}}` placeholders in its URL
`just repo-init` replaces the `hyperpolymath` and `bactrian` placeholders in its URL

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the owner token renderable in the README

When a child is minted under an owner other than hyperpolymath, replacing {{OWNER}} here with the template's literal owner leaves that owner unchanged: the self-name pass rewrites bactrian globally, but SELF_OWNER_SED only operates on Justfile and sonar-project.properties. The resulting child README therefore says that repo-init replaced the hyperpolymath and <child-repo> placeholders even though its badge URL uses the child's actual owner; retain the owner token so the normal substitution pass renders this sentence correctly.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. The cause is upstream: the template's README sentence (line 145) carries the owner and repository tokens as prose, and the mint substitutes README.adoc, so every child reads "replaces the and placeholders". Fixed at source: rsr-template-repo#391 rewords it without tokens and adds a guard. This PR is closed; its content moved to #29, which carries the by-hand fill as a stopgap. Once #391 merges and syncs, the README line in bactrian takes the template wording. Left open until then.


Generated by Claude Code

tests/workflows/mint_cleanup_test.sh # instruction-block fixture
tests/workflows/self_name_pass_test.sh # template-name fixtures
tests/workflows/template_conformance_test.sh # template-slug fixtures
tests/workflows/julia_library_test.sh # PACKAGE_UUID brace-token fixture

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the nonexistent verbatim manifest entry

For any non-chain template mint that reaches the manifest preflight, this entry makes just repo-init abort before prompting or writing because tests/workflows/julia_library_test.sh does not exist in this commit (the available Julia tests are under tests/e2e/). The recipe explicitly checks every MINT_VERBATIM path with [ -f "$_v" ] and exits on a stale entry, so this blocks the template's primary mint path rather than merely excluding the wrong file.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and fixed in the replacement: tests/workflows/julia_library_test.sh is now carried byte-identical in #28 (the replacement for #24), and #29 is stacked on it. All 21 manifest entries exist there. This PR is closed.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Closing in favour of #29, the same content restacked on #28 (the #24 replacement). The only difference is tests/workflows/julia_library_test.sh, which comes from #28. The branch stays for the owner to delete.


Generated by Claude Code

hyperpolymath added a commit that referenced this pull request Nov 14, 2026
…eplaces #26, needs the #24 replacement) (#29)

* chore: carry the template's prose-token documents verbatim

Syncs .machine_readable/mint-verbatim.txt from the template (the list now has the
six prose-token documents) and brings the documents on it that differ here back
to the template's bytes: CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc,
tests/aspect_tests.sh. The damage report, survey-template-damage.sh and
check-mint-tokens.sh already equal the template on main. The mint had rewritten
the template name or the project-name brace token inside their prose; the
mint-token and placeholder gates skip files on the list.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ

* chore: carry tests/workflows/julia_library_test.sh verbatim

mint-verbatim.txt lists it (synced from the template at d183b32) and
repo-init.just exits on a listed file that is absent. Carry the template's
file byte-identical. All 21 manifest entries now exist.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ

* chore: drop the retired .cursorrules and .windsurfrules

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit a7de0af)

* chore: remove the stale build/docs-seed hypatia exemption and refresh the rule order

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit ba3baa5)

* docs: fill the README repo-init sentence with this repository's identity

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit 523eeba)

* fix(abi): fill the foreign-library tokens in Foreign.idr and Types.idr

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit 7f7e602)

* docs: regenerate the repository map

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants